Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1744553002: DM crash handler tweaks (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM crash handler tweaks - try to guard against reentrant signals. - re-raise the signal with the default handler when done printing. - support Windows BUG=589654 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744553002 Committed: https://skia.googlesource.com/skia/+/f85572956473efd8298522acb4bf0ee75cbdb86b

Patch Set 1 #

Patch Set 2 : stdlib #

Patch Set 3 : signal/raise #

Patch Set 4 : win too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
M dm/DM.cpp View 1 2 3 1 chunk +41 lines, -5 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/1
4 years, 10 months ago (2016-02-26 18:24:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/1
4 years, 10 months ago (2016-02-26 18:27:34 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/6604)
4 years, 10 months ago (2016-02-26 18:28:43 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/20001
4 years, 10 months ago (2016-02-26 18:29:49 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/6605)
4 years, 10 months ago (2016-02-26 18:31:37 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/40001
4 years, 10 months ago (2016-02-27 00:20:56 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-27 00:32:01 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/60001
4 years, 10 months ago (2016-02-27 00:33:32 UTC) #21
mtklein_C
Think you can point me (or this CL) at some of the problem trybots?
4 years, 10 months ago (2016-02-27 00:58:47 UTC) #24
borenet
On 2016/02/27 00:58:47, mtklein_C wrote: > Think you can point me (or this CL) at ...
4 years, 9 months ago (2016-02-28 19:45:26 UTC) #25
mtklein_C
Hmm. Hard to say if it doesn't crash. Want to give it a shot? Shouldn't ...
4 years, 9 months ago (2016-02-29 14:06:56 UTC) #26
borenet
On 2016/02/29 14:06:56, mtklein_C wrote: > Hmm. Hard to say if it doesn't crash. Want ...
4 years, 9 months ago (2016-02-29 14:20:27 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/60001
4 years, 9 months ago (2016-02-29 14:25:12 UTC) #29
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 14:35:32 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f85572956473efd8298522acb4bf0ee75cbdb86b

Powered by Google App Engine
This is Rietveld 408576698