|
|
DescriptionDM crash handler tweaks
- try to guard against reentrant signals.
- re-raise the signal with the default handler when done printing.
- support Windows
BUG=589654
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744553002
Committed: https://skia.googlesource.com/skia/+/f85572956473efd8298522acb4bf0ee75cbdb86b
Patch Set 1 #Patch Set 2 : stdlib #Patch Set 3 : signal/raise #Patch Set 4 : win too #Messages
Total messages: 31 (17 generated)
Description was changed from ========== DM crash handler tweaks - call _Exit() to make sure we exit right away, no destructors, no at_exit(), etc. - try to guard against reentrant signals. If our signal handler causes a signal, just skip down to the _Exit() call. BUG=skia: ========== to ========== DM crash handler tweaks - call _Exit() to make sure we exit right away, no destructors, no at_exit(), etc. - try to guard against reentrant signals. If our signal handler causes a signal, just skip down to the _Exit() call. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== DM crash handler tweaks - call _Exit() to make sure we exit right away, no destructors, no at_exit(), etc. - try to guard against reentrant signals. If our signal handler causes a signal, just skip down to the _Exit() call. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== DM crash handler tweaks - call _Exit() to make sure we exit right away, no destructors, no at_exit(), etc. - try to guard against reentrant signals. If our signal handler causes a signal, just skip down to the _Exit() call. BUG=589654 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/1
The CQ bit was unchecked by mtklein@chromium.org
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
Description was changed from ========== DM crash handler tweaks - call _Exit() to make sure we exit right away, no destructors, no at_exit(), etc. - try to guard against reentrant signals. If our signal handler causes a signal, just skip down to the _Exit() call. BUG=589654 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== DM crash handler tweaks - re-raise the signal with the default handler when done printing. - try to guard against reentrant signals. BUG=589654 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== DM crash handler tweaks - re-raise the signal with the default handler when done printing. - try to guard against reentrant signals. BUG=589654 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== DM crash handler tweaks - try to guard against reentrant signals. - re-raise the signal with the default handler when done printing. - support Windows BUG=589654 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/60001
The CQ bit was unchecked by mtklein@chromium.org
mtklein@chromium.org changed reviewers: + borenet@google.com - mtklein@google.com
Think you can point me (or this CL) at some of the problem trybots?
On 2016/02/27 00:58:47, mtklein_C wrote: > Think you can point me (or this CL) at some of the problem trybots? Added the GalaxyS3 trybot which had the issue before. It's not consistent though, so it may not tell us anything?
Hmm. Hard to say if it doesn't crash. Want to give it a shot? Shouldn't be worse.
On 2016/02/29 14:06:56, mtklein_C wrote: > Hmm. Hard to say if it doesn't crash. Want to give it a shot? Shouldn't be > worse. Sure, LGTM
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744553002/60001
Message was sent while issue was closed.
Description was changed from ========== DM crash handler tweaks - try to guard against reentrant signals. - re-raise the signal with the default handler when done printing. - support Windows BUG=589654 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== DM crash handler tweaks - try to guard against reentrant signals. - re-raise the signal with the default handler when done printing. - support Windows BUG=589654 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/f85572956473efd8298522acb4bf0ee75cbdb86b ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/f85572956473efd8298522acb4bf0ee75cbdb86b |