Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1744533002: Revert of New GM that exercises gamma-correctness in various parts of the pipeline. (Closed)

Created:
4 years, 9 months ago by Brian Osman
Modified:
4 years, 9 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of New GM that exercises gamma-correctness in various parts of the pipeline. (patchset #4 id:60001 of https://codereview.chromium.org/1734983003/ ) Reason for revert: Testing revert to fix MacMini? Original issue's description: > New GM that exercises gamma-correctness in various parts of the pipeline. > > Attempts to render 50% grey through many different techniques. Only the first one (black/white dither) is guaranteed to be correct. This serves as ground-truth for all the others (independent of whatever your display may or may not be doing when viewing the output of the GM). > > Current tests: > - Texture bilerp > - Texture scale (ie mipmaps) > - Simple paint color > - Gradient > - A handful of Xfer modes > - 50% grey bitmaps, both linear and sRGB > > Also includes a bug-fix for sRGB -> Linear bitmap case > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734983003 > > Committed: https://skia.googlesource.com/skia/+/9f73a71eec0eb54783f2dcad009aae6aafbe38d5 TBR=bsalomon@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/fe4b4f00d759ef7ac135ea2d104971b7fad66cda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -184 lines) Patch
D gm/gamma.cpp View 1 chunk +0 lines, -166 lines 0 comments Download
M src/core/SkBlitter_Sprite.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/core/SkSpriteBlitter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkSpriteBlitter4f.cpp View 3 chunks +5 lines, -10 lines 0 comments Download
M src/core/SkSpriteBlitter_ARGB32.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Osman
Created Revert of New GM that exercises gamma-correctness in various parts of the pipeline.
4 years, 9 months ago (2016-02-26 17:18:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744533002/1
4 years, 9 months ago (2016-02-26 17:18:54 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 17:19:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fe4b4f00d759ef7ac135ea2d104971b7fad66cda

Powered by Google App Engine
This is Rietveld 408576698