Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1744493003: [arm64] Prevent the compiler to use fmadd/fmsub while compiling cctest. (Closed)

Created:
4 years, 10 months ago by baptiste.afsa1
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Prevent the compiler to use fmadd/fmsub while compiling cctest. This ensures that the generated code output will match the reference code output and fixes some failures when running tests natively. R=bmeurer@chromium.org Committed: https://crrev.com/27a75f7ad0fbde8aab73b7f0858b4c17c6dc981f Cr-Commit-Position: refs/heads/master@{#34354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M test/cctest/cctest.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
baptiste.afsa1
PTAL
4 years, 10 months ago (2016-02-26 14:04:28 UTC) #1
Benedikt Meurer
lgtm
4 years, 10 months ago (2016-02-26 17:24:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744493003/1
4 years, 9 months ago (2016-02-29 09:01:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 09:15:30 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 09:16:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27a75f7ad0fbde8aab73b7f0858b4c17c6dc981f
Cr-Commit-Position: refs/heads/master@{#34354}

Powered by Google App Engine
This is Rietveld 408576698