a little refactoring around identifiers/parameters

a little refactoring around identifiers/parameters

Main goal here is to isolate some code that was treating parameter declarations differently from other SimpleIdentifiers.

(We're going to need to emit generic method instantiations for SimpleIdentifiers in some cases, so it's going to be important to split out parameters from other expressions)

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/8bf87359b8d5cd31f9873fd71b4f9230a5cf5334

[Jennifer Messerly, 2016-02-26 00:27:01]

Description was changed from

==========
a little refactoring around identifiers/parameters
==========

to

==========
a little refactoring around identifiers/parameters

Main goal here is to isolate some code that was treating parameter declarations
differently from other SimpleIdentifiers.

(We're going to need to emit generic method instantiations for SimpleIdentifiers
in some cases, so it's going to be important to split out parameters from other
expressions)
==========

[Jennifer Messerly, 2016-02-26 00:27:01]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2016-02-26 00:31:08]

https://codereview.chromium.org/1744453002/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1744453002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:1618: if (body is ExpressionFunctionBody &&
!destructureNamed) {
this is another bug fix.

What could've happened before: if a lambda had named args, it would've ended up
here but without its destructuring. However, emitting the function body directly
won't emit argument initializers.

Aside: I may see about refactoring this differently at some point. In general,
working around JS bugs/missing features should be the responsibility of the JS
backend, not the Dart->JS transformation.

We have a similar issue right now with "TypeRef". If our compiler is to emit
typed JS AST, IMO it should be used for generating our RTTI. But for now I'm
going to ignore that one, since we have open questions about what the JS types
actually mean. (If I had my way, they'd be DartTypes, and then mapping to JS
types would be another phase.)

[vsm, 2016-02-26 14:31:37]

lgtm

https://codereview.chromium.org/1744453002/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1744453002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:1609: // Chrome Canary does not accept default
values with destructuring in
Is this comment obsolete now?

[Jennifer Messerly, 2016-02-26 17:41:40]

https://codereview.chromium.org/1744453002/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1744453002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:1609: // Chrome Canary does not accept default
values with destructuring in
On 2016/02/26 14:31:37, vsm wrote:
> Is this comment obsolete now?

Oh, about Chrome Canary? I'm not sure. I didn't investigate, figured even if
Canary supports it we might still be stuck with the workaround for
Atom/Electron.

[Jennifer Messerly, 2016-02-26 18:00:18]

Description was changed from

==========
a little refactoring around identifiers/parameters

Main goal here is to isolate some code that was treating parameter declarations
differently from other SimpleIdentifiers.

(We're going to need to emit generic method instantiations for SimpleIdentifiers
in some cases, so it's going to be important to split out parameters from other
expressions)
==========

to

==========
a little refactoring around identifiers/parameters

Main goal here is to isolate some code that was treating parameter declarations
differently from other SimpleIdentifiers.

(We're going to need to emit generic method instantiations for SimpleIdentifiers
in some cases, so it's going to be important to split out parameters from other
expressions)

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/8bf87359b8d5cd31f9873fd71b4f...
==========

[Jennifer Messerly, 2016-02-26 18:00:20]

Committed patchset #1 (id:1) manually as
8bf87359b8d5cd31f9873fd71b4f9230a5cf5334 (presubmit successful).