Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 174443002: Add some unit tests for SyncData. (Closed)

Created:
6 years, 10 months ago by maniscalco
Modified:
6 years, 10 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add some unit tests for SyncData. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252763

Patch Set 1 : ModelType::BOOKMARKS -> syncer::BOOKMARKS #

Total comments: 4

Patch Set 2 : Apply CR feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
sync/api/sync_data_unittest.cc View 1 1 chunk +66 lines, -0 lines 0 comments Download
sync/sync_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
maniscalco
Hi Nicolas, would you please review this change? In a future CL I will be ...
6 years, 10 months ago (2014-02-20 22:20:49 UTC) #1
Nicolas Zea
lgtm https://codereview.chromium.org/174443002/diff/50001/sync/api/sync_data_unittest.cc File sync/api/sync_data_unittest.cc (right): https://codereview.chromium.org/174443002/diff/50001/sync/api/sync_data_unittest.cc#newcode10 sync/api/sync_data_unittest.cc:10: #include "sync/internal_api/public/base_node.h" is this needed? https://codereview.chromium.org/174443002/diff/50001/sync/api/sync_data_unittest.cc#newcode22 sync/api/sync_data_unittest.cc:22: const ...
6 years, 10 months ago (2014-02-21 19:12:00 UTC) #2
maniscalco
https://codereview.chromium.org/174443002/diff/50001/sync/api/sync_data_unittest.cc File sync/api/sync_data_unittest.cc (right): https://codereview.chromium.org/174443002/diff/50001/sync/api/sync_data_unittest.cc#newcode10 sync/api/sync_data_unittest.cc:10: #include "sync/internal_api/public/base_node.h" On 2014/02/21 19:12:00, Nicolas Zea wrote: > ...
6 years, 10 months ago (2014-02-21 19:23:05 UTC) #3
maniscalco
The CQ bit was checked by maniscalco@chromium.org
6 years, 10 months ago (2014-02-21 20:57:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/174443002/180002
6 years, 10 months ago (2014-02-21 20:59:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 22:03:39 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268107
6 years, 10 months ago (2014-02-21 22:03:40 UTC) #7
maniscalco
The CQ bit was checked by maniscalco@chromium.org
6 years, 10 months ago (2014-02-21 22:29:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/174443002/180002
6 years, 10 months ago (2014-02-21 22:31:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/174443002/180002
6 years, 10 months ago (2014-02-22 01:24:06 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 07:57:24 UTC) #11
Message was sent while issue was closed. 
Change committed as 252763

Powered by Google App Engine
This is Rietveld 408576698