Add an Android sample app for Telemetry tests.

Add an Android sample app for Telemetry tests.

The purpose of this app is to be launched and push other apps to
the background during Android telemetry tests. It is just a
super simple Android app.

BUG=586148
Committed: https://crrev.com/f5e98301e0ee9a7a7388df01a1dfa366a95840ed
Cr-Commit-Position: refs/heads/master@{#380680}

[mikecase (-- gone --), 2016-02-29 19:12:12]

mikecase@chromium.org changed reviewers:
+ perezju@chromium.org

[mikecase (-- gone --), 2016-02-29 19:12:12]

Here is a dead simple Android app for pushing apps to the background for
telemetry.

Wasn't sure where to put it so I put it in tools/perf/sample_app (I can move it
if you think of a better place).

[mikecase (-- gone --), 2016-02-29 19:18:10]

mikecase@chromium.org changed reviewers:
+ nednguyen@google.com

[perezju, 2016-02-29 19:29:27]

perezju@chromium.org changed reviewers:
+ jbudorick@chromium.org, primiano@chromium.org

[perezju, 2016-02-29 19:29:27]

Nice! Just a couple of high-level comments.

On the location where to put the code, I'm not quite sure either. But if we plan
to add a "Push back to background" feature to Telemetry, maybe should live in
catapult repo? Otherwise, if we only expect to use tie this app to the perf
benchmark that uses it, perhaps /tools/perf is not a bad idea? Ned, John, what
are your thoughts on this?

Also, maybe we should not include "telemetry" that often everywhere on the app
strings, activity names, etc. I guess we can stick with "hello world", and just
include a comment somewhere stating the intended purpose of the app (namely:
push other apps to the background while running automated user stories).

[mikecase (-- gone --), 2016-02-29 22:18:24]

Removed the word telemetry everywhere and just renamed to HelloWorld.

If I were to move this to Catapult where would I put it. And more importantly,
does Catapult have all the GN/GYP support for Java (like the android_apk GN
template)?

[nednguyen, 2016-03-01 05:33:08]

On 2016/02/29 22:18:24, mikecase wrote:
> Removed the word telemetry everywhere and just renamed to HelloWorld.
> 
> If I were to move this to Catapult where would I put it. And more importantly,
> does Catapult have all the GN/GYP support for Java (like the android_apk GN
> template)?

Currently Catapult does not have GN/GYP support. We usually just prebuild the
binary/apk somewhere & push it to cloud storage, then download it when we need. 

Wouldn't the easier way to push other apps to background is just to launch the
homescreen? http://android.stackexchange.com/a/30158

[jbudorick, 2016-03-01 14:04:30]

On 2016/03/01 05:33:08, nednguyen wrote:
> On 2016/02/29 22:18:24, mikecase wrote:
> > Removed the word telemetry everywhere and just renamed to HelloWorld.
> > 
> > If I were to move this to Catapult where would I put it. And more
importantly,
> > does Catapult have all the GN/GYP support for Java (like the android_apk GN
> > template)?
> 
> Currently Catapult does not have GN/GYP support. We usually just prebuild the
> binary/apk somewhere & push it to cloud storage, then download it when we
need. 
> 
> Wouldn't the easier way to push other apps to background is just to launch the
> homescreen? http://android.stackexchange.com/a/30158

(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapu...)

[mikecase (-- gone --), 2016-03-01 16:15:57]

On 2016/03/01 at 14:04:30, jbudorick wrote:
> On 2016/03/01 05:33:08, nednguyen wrote:
> > On 2016/02/29 22:18:24, mikecase wrote:
> > > Removed the word telemetry everywhere and just renamed to HelloWorld.
> > > 
> > > If I were to move this to Catapult where would I put it. And more
importantly,
> > > does Catapult have all the GN/GYP support for Java (like the android_apk
GN
> > > template)?
> > 
> > Currently Catapult does not have GN/GYP support. We usually just prebuild
the
> > binary/apk somewhere & push it to cloud storage, then download it when we
need. 
> > 
> > Wouldn't the easier way to push other apps to background is just to launch
the
> > homescreen? http://android.stackexchange.com/a/30158
> 
>
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapu...)

According to perezju, the app isn't fully pushed into the background when you
just go to the homescreen, or something
like that. I think it was determined going to the homescreen isn't sufficient
for what we need to do in some of the
memory tests.

[Primiano Tucci (use gerrit), 2016-03-01 16:58:41]

Question: can we not just repurpose the Webview's Telemetry Shell app?
We could add an activity which does NOT have a webview (so if we dont' want a
webview in the benchmark it won't be needed), and one that does have it (which
is already there) for the benchmarks where we need it.
The pro is that we can use a single apk both for webview benchmarks, and for
general benchmarks where we want something in the foreground.
On the good side, it would be just one apk to maintain, no?

[perezju, 2016-03-01 17:55:33]

Re: about the home screen, as far as I remember and doing now a bit of
experimentation, the app goes to the background just fine; the problem is that,
afterwards, pressing "back" won't bring it back to the foreground.

We could go back to Chrome by launching a second intent, but that also has it's
own set of problems. In fact I started writing a design doc about this (would
also be needed for the dual-browser test), I'll share it when it's ready.

Re: using WebView shell as the dummy app; what would happen when we want to
measure background memory for WebView? Do the two activities get different pids?
Is the memory usage of the two activities going to be conflated?

[Primiano Tucci (use gerrit), 2016-03-01 18:21:17]

> Re: using WebView shell as the dummy app; what would happen when we want to
> measure background memory for WebView? Do the two activities get different
pids?
> Is the memory usage of the two activities going to be conflated?
Ohh is your point that we might want to have benchmarks with BOTH a dummy app
and a webview app?
If that is the case, yes you are right, we need two different apps.

[nednguyen, 2016-03-02 01:24:09]

On 2016/03/01 18:21:17, Primiano (throttled til Mar 4) wrote:
> > Re: using WebView shell as the dummy app; what would happen when we want to
> > measure background memory for WebView? Do the two activities get different
> pids?
> > Is the memory usage of the two activities going to be conflated?
> Ohh is your point that we might want to have benchmarks with BOTH a dummy app
> and a webview app?
> If that is the case, yes you are right, we need two different apps.

Whether we will move this to telemetry depending on whether we will need this
for system health benchmarks. 

If we move this to telemetry, we should rename the app a bit to make it clear
what this is use for. Maybe PushAppsToBackgroundActivity.java

[mikecase (-- gone --), 2016-03-07 19:28:13]

renamed to PushAppsToBackgroundActivity.java as Ned suggested.

[nednguyen, 2016-03-07 19:31:40]

On 2016/03/07 19:28:13, mikecase wrote:
> renamed to PushAppsToBackgroundActivity.java as Ned suggested.

lgtm

[Primiano Tucci (use gerrit), 2016-03-08 12:09:24]

lgtm

https://codereview.chromium.org/1744423002/diff/100001/tools/perf/perf_helper...
File tools/perf/perf_helper_app/res/values/strings.xml (right):

https://codereview.chromium.org/1744423002/diff/100001/tools/perf/perf_helper...
tools/perf/perf_helper_app/res/values/strings.xml:12: <b>Oh my God</b>."
LOL

[perezju, 2016-03-08 12:19:48]

thanks! lgtm too

I guess having the code for the app in tools/perf is fine too.

[Primiano Tucci (use gerrit), 2016-03-08 13:04:29]

On 2016/03/08 12:19:48, perezju wrote:
> thanks! lgtm too
> 
> I guess having the code for the app in tools/perf is fine too.

OH thanks for reminding.
Most of the android apps we use are under tools/android.
not sure about tools/perf/ (ned? ethan?)
Also consider that if we plan to move tools/perf into catapult, we cannot have
code which depends on the rest of the tree there.
So thinking a bit more, probably //tools/android is a better location, ned WDYT?

[nednguyen, 2016-03-08 16:06:25]

On 2016/03/08 13:04:29, Primiano wrote:
> On 2016/03/08 12:19:48, perezju wrote:
> > thanks! lgtm too
> > 
> > I guess having the code for the app in tools/perf is fine too.
> 
> OH thanks for reminding.
> Most of the android apps we use are under tools/android.
> not sure about tools/perf/ (ned? ethan?)
> Also consider that if we plan to move tools/perf into catapult, we cannot have
> code which depends on the rest of the tree there.
> So thinking a bit more, probably //tools/android is a better location, ned
WDYT?

We don't have any plan to move tools/perf into catapult. Putting that aside,
moving this to //tools/android is ok to me. But you may want to update the
isolate & BUILD.gn in perf/ to include that outside dependency.

[mikecase (-- gone --), 2016-03-09 20:53:44]

mikecase@chromium.org changed reviewers:
+ yfriedman@chromium.org

[mikecase (-- gone --), 2016-03-09 20:53:45]

Moved app to tools/android as suggested. Renamed some things from
"perf_helper_app" or "perf_helper" to just "push_apps_to_background" since there
are several things in tools/android
that look like they could be called "perf_helper".

+ yfriedman@chromium.org for OWNERS review of tools/android

[Yaron, 2016-03-10 03:16:02]

owners lgtm

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
File tools/android/push_apps_to_background/OWNERS (right):

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
tools/android/push_apps_to_background/OWNERS:1: mikecase@chromium.org
you should ideally have multiple owners.. perhaps one of the reviewers?

[nednguyen, 2016-03-10 03:17:01]

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
File tools/android/push_apps_to_background/OWNERS (right):

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
tools/android/push_apps_to_background/OWNERS:1: mikecase@chromium.org
On 2016/03/10 03:16:02, Yaron wrote:
> you should ideally have multiple owners.. perhaps one of the reviewers?

I would suggest putting perezju@

[perezju, 2016-03-10 10:19:15]

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
File tools/android/push_apps_to_background/OWNERS (right):

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
tools/android/push_apps_to_background/OWNERS:1: mikecase@chromium.org
On 2016/03/10 03:17:01, nednguyen wrote:
> On 2016/03/10 03:16:02, Yaron wrote:
> > you should ideally have multiple owners.. perhaps one of the reviewers?
> 
> I would suggest putting perezju@

sgtm.

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
File
tools/android/push_apps_to_background/src/org/chromium/push_apps_to_background/PushAppsToBackgroundActivity.java
(right):

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
tools/android/push_apps_to_background/src/org/chromium/push_apps_to_background/PushAppsToBackgroundActivity.java:11:
* This activity is used in performance test to push other apps
nit: performance test -> performance tests

[mikecase (-- gone --), 2016-03-10 17:55:09]

mikecase@chromium.org changed reviewers:
+ dpranke@chromium.org

[mikecase (-- gone --), 2016-03-10 17:55:10]

hmmm, looks like I forgot to add an OWNER for src/BUILD.gn as well  :/

+ dpranke@chromium.org

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
File tools/android/push_apps_to_background/OWNERS (right):

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
tools/android/push_apps_to_background/OWNERS:1: mikecase@chromium.org
On 2016/03/10 at 10:19:14, perezju wrote:
> On 2016/03/10 03:17:01, nednguyen wrote:
> > On 2016/03/10 03:16:02, Yaron wrote:
> > > you should ideally have multiple owners.. perhaps one of the reviewers?
> > 
> > I would suggest putting perezju@
> 
> sgtm.

Done

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
File
tools/android/push_apps_to_background/src/org/chromium/push_apps_to_background/PushAppsToBackgroundActivity.java
(right):

https://codereview.chromium.org/1744423002/diff/120001/tools/android/push_app...
tools/android/push_apps_to_background/src/org/chromium/push_apps_to_background/PushAppsToBackgroundActivity.java:11:
* This activity is used in performance test to push other apps
On 2016/03/10 at 10:19:14, perezju wrote:
> nit: performance test -> performance tests

Done

[Dirk Pranke, 2016-03-10 18:13:35]

//BUILD.gn, //build lgtm except I'd like you to add the binary name to the
appropriate place in //build/gn_migration.gypi ...

[mikecase (-- gone --), 2016-03-10 20:22:00]

On 2016/03/10 at 18:13:35, dpranke wrote:
> //BUILD.gn, //build lgtm except I'd like you to add the binary name to the
appropriate place in //build/gn_migration.gypi ...

Done

[mikecase (-- gone --), 2016-03-10 20:22:04]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2016-03-10 20:22:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org, nednguyen@google.com, perezju@chromium.org,
yfriedman@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1744423002/#ps160001
(title: "Updated gn_migration.gypi")

[commit-bot: I haz the power, 2016-03-10 20:22:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744423002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744423002/160001

[commit-bot: I haz the power, 2016-03-10 21:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 21:09:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mikecase (-- gone --), 2016-03-11 17:45:00]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-03-11 17:45:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744423002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744423002/160001

[commit-bot: I haz the power, 2016-03-11 18:38:47]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-03-11 18:40:37]

Description was changed from

==========
Add an Android sample app for Telemetry tests.

The purpose of this app is to be launched and push other apps to
the background during Android telemetry tests. It is just a
super simple Android app.

BUG=586148
==========

to

==========
Add an Android sample app for Telemetry tests.

The purpose of this app is to be launched and push other apps to
the background during Android telemetry tests. It is just a
super simple Android app.

BUG=586148

Committed: https://crrev.com/f5e98301e0ee9a7a7388df01a1dfa366a95840ed
Cr-Commit-Position: refs/heads/master@{#380680}
==========

[commit-bot: I haz the power, 2016-03-11 18:40:38]

Patchset 9 (id:??) landed as
https://crrev.com/f5e98301e0ee9a7a7388df01a1dfa366a95840ed
Cr-Commit-Position: refs/heads/master@{#380680}