Fix to_boolean type feedback for unary and binary ops

src/ast.h

Index: src/ast.h
diff --git a/src/ast.h b/src/ast.h
index 249f7c0149be72cbfc7eb34da83e0b05c5511fb7..089bbe3be23847fc331d824418f457c3a3177214 100644
--- a/src/ast.h
+++ b/src/ast.h
@@ -383,7 +383,7 @@ class Expression: public AstNode {
   }
 
   // TODO(rossberg): this should move to its own AST node eventually.
-  void RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle);
+  virtual void RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle);
   byte to_boolean_types() const { return to_boolean_types_; }
 
   BailoutId id() const { return id_; }
@@ -395,11 +395,11 @@ class Expression: public AstNode {
         lower_type_(Type::None(), isolate),
         id_(GetNextId(isolate)),
         test_id_(GetNextId(isolate)) {}
+  byte to_boolean_types_;

[Jakob Kummerow, 2013/06/24 15:06:35]

nit: the style guide forbids non-private fields. Use a protected setter, leave
the field itself private.

 
  private:
   Handle<Type> upper_type_;
   Handle<Type> lower_type_;
-  byte to_boolean_types_;
 
   const BailoutId id_;
   const TypeFeedbackId test_id_;
@@ -1841,6 +1841,8 @@ class UnaryOperation: public Expression {
 
   TypeFeedbackId UnaryOperationFeedbackId() const { return reuse(id()); }
 
+  virtual void RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle);
+
  protected:
   UnaryOperation(Isolate* isolate,
                  Token::Value op,
@@ -1884,6 +1886,8 @@ class BinaryOperation: public Expression {
   Maybe<int> fixed_right_arg() const { return fixed_right_arg_; }
   void set_fixed_right_arg(Maybe<int> arg) { fixed_right_arg_ = arg; }
 
+  virtual void RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle);
+
  protected:
   BinaryOperation(Isolate* isolate,
                   Token::Value op,