src/ast.cc - Issue 17444011: Fix to_boolean type feedback for unary and binary ops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 17444011: Fix to_boolean type feedback for unary and binary ops (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index f2ec67f69b7efb899e937089759f2f5d6a6c9cb5..d2e823c34fa9d9cb9966cdfbde20dfd52d2b5cc7 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -428,7 +428,13 @@ void ForInStatement::RecordTypeFeedback(TypeFeedbackOracle* oracle) {

void Expression::RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle) {

- to_boolean_types_ = oracle->ToBooleanTypes(test_id());

+ to_boolean_types_ |= oracle->ToBooleanTypes(test_id());

+void Expression::RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle,

+ TypeFeedbackId origin) {

Jakob Kummerow 2013/06/24 09:25:07 nit: align arguments with each other

+ to_boolean_types_ |= oracle->ToBooleanTypes(origin);

}