Fix to_boolean type feedback for unary and binary ops

src/ast.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 270 matching lines @@
 void TargetCollector::AddTarget(Label* target, Zone* zone) {
   // Add the label to the collector, but discard duplicates.
   int length = targets_.length();
   for (int i = 0; i < length; i++) {
     if (targets_[i] == target) return;
   }
   targets_.Add(target, zone);
 }
 
 
+void UnaryOperation::RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle) {
+  // TODO(oli) If this Operation is used in a test context, then the expression

[Jakob Kummerow, 2013/06/24 15:06:35]

nit: the identifier in the parentheses should be the @chromium.org username, so
"olivf" in your case.

+  // has a ToBool stub and we want to collect this information. However the

[Jakob Kummerow, 2013/06/24 15:06:35]

nit: s/ToBool/ToBoolean/

+  // GraphBuilder expects it to be on the instruction corresponding to the
+  // TestContext, therefore we have to store it here and not on the operand.
+  to_boolean_types_ = oracle->ToBooleanTypes(expression()->test_id());
+}
+
+
 bool UnaryOperation::ResultOverwriteAllowed() {
   switch (op_) {
     case Token::BIT_NOT:
     case Token::SUB:
       return true;
     default:
       return false;
   }
 }
 
 
+void BinaryOperation::RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle) {
+  // TODO(oli) If this Operation is used in a test context, then the right
+  // hand side has a ToBool stub and we want to collect this information.
+  // However the GraphBuilder expects it to be on the instruction corresponding
+  // to the TestContext, therefore we have to store it here and not on the
+  // right hand operand.
+  to_boolean_types_ = oracle->ToBooleanTypes(right()->test_id());
+}
+
+
 bool BinaryOperation::ResultOverwriteAllowed() {
   switch (op_) {
     case Token::COMMA:
     case Token::OR:
     case Token::AND:
       return false;
     case Token::BIT_OR:
     case Token::BIT_XOR:
     case Token::BIT_AND:
     case Token::SHL:
@@ skipping 851 matching lines @@
     OS::SNPrintF(buffer, "%d", Smi::cast(*handle_)->value());
     str = arr;
   } else {
     str = DoubleToCString(handle_->Number(), buffer);
   }
   return factory->NewStringFromAscii(CStrVector(str));
 }
 
 
 } }  // namespace v8::internal