Fix to_boolean type feedback for unary and binary ops

src/typing.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 391 matching lines @@
 
 void AstTyper::VisitUnaryOperation(UnaryOperation* expr) {
   ASSERT(!HasStackOverflow());
   CHECK_ALIVE(Visit(expr->expression()));
 
   // Collect type feedback.
   Handle<Type> op_type = oracle()->UnaryType(expr->UnaryOperationFeedbackId());
   MergeLowerType(expr->expression(), op_type);
   if (expr->op() == Token::NOT) {
     // TODO(rossberg): only do in test or value context.
-    expr->expression()->RecordToBooleanTypeFeedback(oracle());
+    expr->RecordToBooleanTypeFeedback(oracle(), expr->expression()->test_id());
   }
 }
 
 
 void AstTyper::VisitCountOperation(CountOperation* expr) {
   ASSERT(!HasStackOverflow());
   CHECK_ALIVE(Visit(expr->expression()));
 
   expr->RecordTypeFeedback(oracle(), zone());
   Property* prop = expr->expression()->AsProperty();
@@ skipping 11 matching lines @@
   // Collect type feedback.
   Handle<Type> type, left_type, right_type;
   Maybe<int> fixed_right_arg;
   oracle()->BinaryType(expr->BinaryOperationFeedbackId(),
       &left_type, &right_type, &type, &fixed_right_arg);
   MergeLowerType(expr, type);
   MergeLowerType(expr->left(), left_type);
   MergeLowerType(expr->right(), right_type);
   expr->set_fixed_right_arg(fixed_right_arg);
   if (expr->op() == Token::OR || expr->op() == Token::AND) {
-    expr->left()->RecordToBooleanTypeFeedback(oracle());
+    expr->RecordToBooleanTypeFeedback(oracle(), expr->left()->test_id());

[Jakob Kummerow, 2013/06/24 09:25:07]

I don't think this change is correct, seeing that in hydrogen.cc:9584 the type
feedback is read specifically from expr->left:

ToBooleanStub::Types expected(expr->left()->to_boolean_types());

+    expr->RecordToBooleanTypeFeedback(oracle(), expr->right()->test_id());
   }
 }
 
 
 void AstTyper::VisitCompareOperation(CompareOperation* expr) {
   ASSERT(!HasStackOverflow());
   CHECK_ALIVE(Visit(expr->left()));
   CHECK_ALIVE(Visit(expr->right()));
 
   // Collect type feedback.
@@ skipping 70 matching lines @@
 }
 
 
 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
   ASSERT(!HasStackOverflow());
   CHECK_ALIVE(Visit(stmt->body()));
 }
 
 
 } }  // namespace v8::internal