Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 17444011: Fix to_boolean type feedback for unary and binary ops (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2222 matching lines...) Expand 10 before | Expand all | Expand 10 after
2233 __ FCmp(); 2233 __ FCmp();
2234 } 2234 }
2235 __ j(zero, instr->FalseLabel(chunk_)); 2235 __ j(zero, instr->FalseLabel(chunk_));
2236 __ jmp(instr->TrueLabel(chunk_)); 2236 __ jmp(instr->TrueLabel(chunk_));
2237 __ bind(&not_heap_number); 2237 __ bind(&not_heap_number);
2238 } 2238 }
2239 2239
2240 if (!expected.IsGeneric()) { 2240 if (!expected.IsGeneric()) {
2241 // We've seen something for the first time -> deopt. 2241 // We've seen something for the first time -> deopt.
2242 // This can only happen if we are not generic already. 2242 // This can only happen if we are not generic already.
2243 DeoptimizeIf(no_condition, instr->environment()); 2243 if (!info()->IsStub()) {
rossberg 2013/06/24 08:54:16 This seems redundant, given that DeoptimizeIf alre
2244 SoftDeoptimize(instr->environment());
2245 } else {
2246 DeoptimizeIf(no_condition, instr->environment());
2247 }
2244 } 2248 }
2245 } 2249 }
2246 } 2250 }
2247 } 2251 }
2248 2252
2249 2253
2250 void LCodeGen::EmitGoto(int block) { 2254 void LCodeGen::EmitGoto(int block) {
2251 if (!IsNextEmittedBlock(block)) { 2255 if (!IsNextEmittedBlock(block)) {
2252 __ jmp(chunk_->GetAssemblyLabel(LookupDestination(block))); 2256 __ jmp(chunk_->GetAssemblyLabel(LookupDestination(block)));
2253 } 2257 }
(...skipping 4306 matching lines...) Expand 10 before | Expand all | Expand 10 after
6560 FixedArray::kHeaderSize - kPointerSize)); 6564 FixedArray::kHeaderSize - kPointerSize));
6561 __ bind(&done); 6565 __ bind(&done);
6562 } 6566 }
6563 6567
6564 6568
6565 #undef __ 6569 #undef __
6566 6570
6567 } } // namespace v8::internal 6571 } } // namespace v8::internal
6568 6572
6569 #endif // V8_TARGET_ARCH_IA32 6573 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698