Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: trunk/src/chrome/browser/ui/search/instant_test_utils.cc

Issue 17444007: Revert 207790 "InstantExtended: Don't create overlay, again." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/search/instant_test_utils.cc
===================================================================
--- trunk/src/chrome/browser/ui/search/instant_test_utils.cc (revision 207797)
+++ trunk/src/chrome/browser/ui/search/instant_test_utils.cc (working copy)
@@ -118,13 +118,27 @@
}
}
-void InstantTestBase::FocusOmniboxAndWaitForInstantNTPSupport() {
+void InstantTestBase::FocusOmniboxAndWaitForInstantOverlaySupport() {
+ content::WindowedNotificationObserver observer(
+ chrome::NOTIFICATION_INSTANT_OVERLAY_SUPPORT_DETERMINED,
+ content::NotificationService::AllSources());
+ FocusOmnibox();
+ if (!instant()->overlay() || !instant()->overlay()->supports_instant())
+ observer.Wait();
+}
+
+void InstantTestBase::FocusOmniboxAndWaitForInstantOverlayAndNTPSupport() {
content::WindowedNotificationObserver ntp_observer(
chrome::NOTIFICATION_INSTANT_NTP_SUPPORT_DETERMINED,
content::NotificationService::AllSources());
+ content::WindowedNotificationObserver overlay_observer(
+ chrome::NOTIFICATION_INSTANT_OVERLAY_SUPPORT_DETERMINED,
+ content::NotificationService::AllSources());
FocusOmnibox();
if (!instant()->ntp() || !instant()->ntp()->supports_instant())
ntp_observer.Wait();
+ if (!instant()->overlay() || !instant()->overlay()->supports_instant())
+ overlay_observer.Wait();
}
void InstantTestBase::SetOmniboxText(const std::string& text) {
« no previous file with comments | « trunk/src/chrome/browser/ui/search/instant_test_utils.h ('k') | trunk/src/chrome/browser/ui/search/local_ntp_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698