Issue 17444007: Revert 207790 "InstantExtended: Don't create overlay, again."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17444007: Revert 207790 "InstantExtended: Don't create overlay, again." (Closed)

Created:
7 years, 6 months ago by Dmitry Zvorygin

Modified:
7 years, 6 months ago

Reviewers:
Jered

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 207790 "InstantExtended: Don't create overlay, again." Flaky tests were restored without removing flakiness. > InstantExtended: Don't create overlay, again. > > Also, re-enable 25 of our tests that were randomly commented out. > Several don't work anymore. > > BUG=247717 > TEST=Yes. > TBR=samarth@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/17523002 TBR=jered@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207798

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1725 lines, -126 lines)			Patch
M	trunk/src/chrome/browser/ui/search/instant_controller.h	View	2 chunks	+37 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/search/instant_controller.cc	View	10 chunks	+17 lines, -15 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/search/instant_extended_interactive_uitest.cc	View	42 chunks	+1610 lines, -93 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc	View	3 chunks	+43 lines, -12 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/search/instant_test_utils.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/search/instant_test_utils.cc	View	1 chunk	+15 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/search/local_ntp_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r207798.