Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1744193002: [esnext] stage Object.values/entries, Object.getOwnPropertyDescriptors (Closed)

Created:
4 years, 9 months ago by caitp (gmail)
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[esnext] stage Object.values/entries, Object.getOwnPropertyDescriptors BUG=v8:4663, v8:4725 LOG=N R=littledan@chromium.org, adamk@chromium.org Committed: https://crrev.com/008981cf12e9b9049cbd25b216e80fe45cd6e172 Cr-Commit-Position: refs/heads/master@{#34399}

Patch Set 1 #

Patch Set 2 : unskip test262 bits #

Patch Set 3 : Rebase on top of that ToName() CL so that infra is happy, hopefully #

Patch Set 4 : Add exceptions for O.gOPDs test bugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M src/flag-definitions.h View 1 chunk +7 lines, -7 lines 0 comments Download
M test/test262/test262.status View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
caitp (gmail)
PTAL --- as discussed briefly by email, I believe these are fairly low risk for ...
4 years, 9 months ago (2016-02-29 14:36:05 UTC) #1
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-02-29 16:36:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744193002/60001
4 years, 9 months ago (2016-02-29 18:43:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/16220)
4 years, 9 months ago (2016-02-29 19:02:45 UTC) #6
caitp (gmail)
On 2016/02/29 19:02:45, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-02-29 20:44:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744193002/60001
4 years, 9 months ago (2016-03-01 15:47:43 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-01 16:14:36 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 16:15:53 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/008981cf12e9b9049cbd25b216e80fe45cd6e172
Cr-Commit-Position: refs/heads/master@{#34399}

Powered by Google App Engine
This is Rietveld 408576698