src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1744163002: [stubs] Introduce a proper ToBooleanStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1744163002: [stubs] Introduce a proper ToBooleanStub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix mips Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index aea0515cd9b3b66ad9302fdc9330936f5111cbca..8ad443ebc86d3aa703e8d64a530aebdd0f9de630 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -595,7 +595,7 @@ void FullCodeGenerator::DoTest(Expression* condition,

Label* if_true,

Label* if_false,

Label* fall_through) {

- Handle<Code> ic = ToBooleanStub::GetUninitialized(isolate());

+ Handle<Code> ic = ToBooleanICStub::GetUninitialized(isolate());

CallIC(ic, condition->test_id());

__ CompareRoot(result_register(), Heap::kTrueValueRootIndex);

Split(equal, if_true, if_false, fall_through);