src/crankshaft/arm64/lithium-arm64.cc - Issue 1744163002: [stubs] Introduce a proper ToBooleanStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/arm64/lithium-arm64.cc

Issue 1744163002: [stubs] Introduce a proper ToBooleanStub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix mips Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/arm64/lithium-arm64.cc

diff --git a/src/crankshaft/arm64/lithium-arm64.cc b/src/crankshaft/arm64/lithium-arm64.cc

index 39381d87bfdbad82283cacbafc097dd29a955bc8..603cbacc4b1138db54a69a0017a46a7fdb6b7539 100644

--- a/src/crankshaft/arm64/lithium-arm64.cc

+++ b/src/crankshaft/arm64/lithium-arm64.cc

@@ -972,7 +972,7 @@ LInstruction* LChunkBuilder::DoBranch(HBranch* instr) {

return new(zone()) LBranch(UseRegister(value), TempRegister(), NULL);

}

- ToBooleanStub::Types expected = instr->expected_input_types();

+ ToBooleanICStub::Types expected = instr->expected_input_types();

bool needs_temps = expected.NeedsMap() || expected.IsEmpty();

LOperand* temp1 = needs_temps ? TempRegister() : NULL;

LOperand* temp2 = needs_temps ? TempRegister() : NULL;