Revert of net: merge two versions of SetTCPNoDelay() function into one

Revert of net: merge two versions of SetTCPNoDelay() function into one (patchset #4 id:60001 of https://codereview.chromium.org/1728853006/ )

Reason for revert:
net-unittests failure on Mac.
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/16976/steps/net_unittests%20on%20Mac-10.9/logs/CertVerifyProcTest.CybertrustGTERoot

Original issue's description:
> net: merge DisableNagle() with two other SetTCPNoDelay() implementations
>
> This patch merges SetTCPNoDelay() function from tcp_socket_posix.cc,
> SetTCPNoDelay() function from tcp_socket_util.cc and DisableNagle() function
> from tcp_socket_win.cc, into a single slightly improved one in tcp_socket.cc
> with the following prototype:
>
> bool SetTCPNoDelay(SocketDescriptor socket, bool no_delay);
>
> BUG=None
> TEST=net_unittests
> R=eroman@chromium.org
>
> Committed: https://crrev.com/2d1f2621d8e6dd10feba6cab380fb46d60cb3098
> Cr-Commit-Position: refs/heads/master@{#378129}

TBR=eroman@chromium.org,tfarina@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None

Committed: https://crrev.com/5ee686747816a494180aad0bce62fbea9dac0f61
Cr-Commit-Position: refs/heads/master@{#378335}

[nektarios, 2016-02-29 21:03:01]

Created Revert of net: merge two versions of SetTCPNoDelay() function into one

[commit-bot: I haz the power, 2016-02-29 21:03:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744153003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744153003/1

[commit-bot: I haz the power, 2016-02-29 21:31:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744153003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744153003/1

[commit-bot: I haz the power, 2016-02-29 22:02:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744153003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744153003/1

[eroman, 2016-02-29 22:20:42]

Hm, sounds unlikely to me that this change could have broken those tests.

That said, seems fine to experiment with a revert here, will be easy to re-apply
if proven innocent.

[commit-bot: I haz the power, 2016-02-29 22:32:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744153003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744153003/1

[commit-bot: I haz the power, 2016-02-29 23:01:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744153003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744153003/1

[commit-bot: I haz the power, 2016-02-29 23:32:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744153003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744153003/1

[commit-bot: I haz the power, 2016-03-01 00:02:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744153003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744153003/1

[commit-bot: I haz the power, 2016-03-01 00:09:55]

Committed patchset #1 (id:1)

[eroman, 2016-03-01 00:11:03]

See https://bugs.chromium.org/p/chromium/issues/detail?id=590868#c3 

From a cursory look, doesn't appear this revert will fix the test failure in
question

[commit-bot: I haz the power, 2016-03-01 00:11:06]

Description was changed from

==========
Revert of net: merge two versions of SetTCPNoDelay() function into one (patchset
#4 id:60001 of https://codereview.chromium.org/1728853006/ )

Reason for revert:
net-unittests failure on Mac.
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/169...

Original issue's description:
> net: merge DisableNagle() with two other SetTCPNoDelay() implementations
> 
> This patch merges SetTCPNoDelay() function from tcp_socket_posix.cc,
> SetTCPNoDelay() function from tcp_socket_util.cc and DisableNagle() function
> from tcp_socket_win.cc, into a single slightly improved one in tcp_socket.cc
> with the following prototype:
> 
> bool SetTCPNoDelay(SocketDescriptor socket, bool no_delay);
> 
> BUG=None
> TEST=net_unittests
> R=eroman@chromium.org
> 
> Committed: https://crrev.com/2d1f2621d8e6dd10feba6cab380fb46d60cb3098
> Cr-Commit-Position: refs/heads/master@{#378129}

TBR=eroman@chromium.org,tfarina@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
==========

to

==========
Revert of net: merge two versions of SetTCPNoDelay() function into one (patchset
#4 id:60001 of https://codereview.chromium.org/1728853006/ )

Reason for revert:
net-unittests failure on Mac.
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/169...

Original issue's description:
> net: merge DisableNagle() with two other SetTCPNoDelay() implementations
>
> This patch merges SetTCPNoDelay() function from tcp_socket_posix.cc,
> SetTCPNoDelay() function from tcp_socket_util.cc and DisableNagle() function
> from tcp_socket_win.cc, into a single slightly improved one in tcp_socket.cc
> with the following prototype:
>
> bool SetTCPNoDelay(SocketDescriptor socket, bool no_delay);
>
> BUG=None
> TEST=net_unittests
> R=eroman@chromium.org
>
> Committed: https://crrev.com/2d1f2621d8e6dd10feba6cab380fb46d60cb3098
> Cr-Commit-Position: refs/heads/master@{#378129}

TBR=eroman@chromium.org,tfarina@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None

Committed: https://crrev.com/5ee686747816a494180aad0bce62fbea9dac0f61
Cr-Commit-Position: refs/heads/master@{#378335}
==========

[commit-bot: I haz the power, 2016-03-01 00:11:07]

Patchset 1 (id:??) landed as
https://crrev.com/5ee686747816a494180aad0bce62fbea9dac0f61
Cr-Commit-Position: refs/heads/master@{#378335}

[tfarina, 2016-03-01 13:31:59]

Ah! Really it was reverted? :(

Eric, could I revert this revert safely?

Thanks!

[eroman, 2016-03-01 18:29:11]

Yes, you can re-land this

[tfarina, 2016-03-01 18:52:47]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1756503002/ by tfarina@chromium.org.

The reason for reverting is: It was not responsible for the failure on Mac - 
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/169....

See https://bugs.chromium.org/p/chromium/issues/detail?id=590868#c3.