WTF::bind: Handle movable objects in unbound arguments.

WTF::bind: Handle movable objects in unbound arguments.

This patch is the complement to an earlier patch
(https://codereview.chromium.org/1708183002/), which did the same thing
for bound arguments.

Fix for unbound arguments is simpler than that for bound arguments. We
just need to make sure the arguments are passed correctly throughout the
process.

Due to the current implementation where we use a virtual function to
implement PartBoundFunctionImpl::operator() we need to copy- or
move-construct a value there, if the argument's type is not a
reference. This is extra cost, but it's probably not feasible to get rid
of this overhead with the current design.

More comments and tests are added accordingly.

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org

Committed: https://crrev.com/cbf29aa70a0a46e631f77e6b6256a3771a09b994
Cr-Commit-Position: refs/heads/master@{#378372}

[Yuta Kitamura, 2016-02-29 08:10:01]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 08:10:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744143002/1

[Yuta Kitamura, 2016-02-29 08:13:12]

PTAL

[tzik, 2016-02-29 08:21:00]

lgtm

[Mikhail, 2016-02-29 08:46:48]

mikhail.pozdnyakov@intel.com changed reviewers:
+ mikhail.pozdnyakov@intel.com

[Mikhail, 2016-02-29 08:46:49]

lgtm

[haraken, 2016-02-29 08:50:34]

LGTM

[commit-bot: I haz the power, 2016-02-29 09:32:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 09:32:52]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2016-03-01 02:15:33]

Landing this now.

hiroshige: Speak up if you find anything as usual.

[Yuta Kitamura, 2016-03-01 02:15:41]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2016-03-01 02:16:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744143002/1

[commit-bot: I haz the power, 2016-03-01 02:22:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-01 02:23:30]

Description was changed from

==========
WTF::bind: Handle movable objects in unbound arguments.

This patch is the complement to an earlier patch
(https://codereview.chromium.org/1708183002/), which did the same thing
for bound arguments.

Fix for unbound arguments is simpler than that for bound arguments. We
just need to make sure the arguments are passed correctly throughout the
process.

Due to the current implementation where we use a virtual function to
implement PartBoundFunctionImpl::operator() we need to copy- or
move-construct a value there, if the argument's type is not a
reference. This is extra cost, but it's probably not feasible to get rid
of this overhead with the current design.

More comments and tests are added accordingly.

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org
==========

to

==========
WTF::bind: Handle movable objects in unbound arguments.

This patch is the complement to an earlier patch
(https://codereview.chromium.org/1708183002/), which did the same thing
for bound arguments.

Fix for unbound arguments is simpler than that for bound arguments. We
just need to make sure the arguments are passed correctly throughout the
process.

Due to the current implementation where we use a virtual function to
implement PartBoundFunctionImpl::operator() we need to copy- or
move-construct a value there, if the argument's type is not a
reference. This is extra cost, but it's probably not feasible to get rid
of this overhead with the current design.

More comments and tests are added accordingly.

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org

Committed: https://crrev.com/cbf29aa70a0a46e631f77e6b6256a3771a09b994
Cr-Commit-Position: refs/heads/master@{#378372}
==========

[commit-bot: I haz the power, 2016-03-01 02:23:32]

Patchset 1 (id:??) landed as
https://crrev.com/cbf29aa70a0a46e631f77e6b6256a3771a09b994
Cr-Commit-Position: refs/heads/master@{#378372}

[Finnur, 2016-03-02 11:47:28]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1757873002/ by finnur@chromium.org.

The reason for reverting is: Speculative revert to see if it fixes leaks in
WebKit tests on Linux that started when this CL was checked in:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...

Only two other changes (besides this CL) went into that build (one being Mac
only) and this CL happens to be the only checkin to WebKit directly. Will reland
if not the culprit..