src/full-codegen/full-codegen.cc - Issue 1744123003: [debugger] fix break locations for assignments and return.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 1744123003: [debugger] fix break locations for assignments and return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fixes and addressed comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index 9d31c3443153201aa2f5f98cc7d0cd341f1d1890..1c7a02bf12fa6c06790176493fb59c77c779f4b0 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -851,7 +851,6 @@ void FullCodeGenerator::VisitForTypeofValue(Expression* expr) {

void FullCodeGenerator::VisitBlock(Block* stmt) {

Comment cmnt(masm_, "[ Block");

NestedBlock nested_block(this, stmt);

- SetStatementPosition(stmt);

{

EnterBlockScopeIfNeeded block_scope_state(

« no previous file with comments | « src/debug/debug.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »