Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: src/debug/debug.h

Issue 1744123003: [debugger] fix break locations for assignments and return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixes and addressed comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_DEBUG_H_ 5 #ifndef V8_DEBUG_DEBUG_H_
6 #define V8_DEBUG_DEBUG_H_ 6 #define V8_DEBUG_DEBUG_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/assembler.h" 10 #include "src/assembler.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 while (count-- > 0) Next(); 135 while (count-- > 0) Next();
136 } 136 }
137 137
138 virtual int code_offset() = 0; 138 virtual int code_offset() = 0;
139 int break_index() const { return break_index_; } 139 int break_index() const { return break_index_; }
140 inline int position() const { return position_; } 140 inline int position() const { return position_; }
141 inline int statement_position() const { return statement_position_; } 141 inline int statement_position() const { return statement_position_; }
142 142
143 protected: 143 protected:
144 explicit Iterator(Handle<DebugInfo> debug_info); 144 explicit Iterator(Handle<DebugInfo> debug_info);
145 int ReturnPosition();
145 146
146 Handle<DebugInfo> debug_info_; 147 Handle<DebugInfo> debug_info_;
147 int break_index_; 148 int break_index_;
148 int position_; 149 int position_;
149 int statement_position_; 150 int statement_position_;
150 151
151 private: 152 private:
152 DisallowHeapAllocation no_gc_; 153 DisallowHeapAllocation no_gc_;
153 DISALLOW_COPY_AND_ASSIGN(Iterator); 154 DISALLOW_COPY_AND_ASSIGN(Iterator);
154 }; 155 };
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
793 Handle<Code> code); 794 Handle<Code> code);
794 static bool DebugBreakSlotIsPatched(Address pc); 795 static bool DebugBreakSlotIsPatched(Address pc);
795 static void ClearDebugBreakSlot(Isolate* isolate, Address pc); 796 static void ClearDebugBreakSlot(Isolate* isolate, Address pc);
796 }; 797 };
797 798
798 799
799 } // namespace internal 800 } // namespace internal
800 } // namespace v8 801 } // namespace v8
801 802
802 #endif // V8_DEBUG_DEBUG_H_ 803 #endif // V8_DEBUG_DEBUG_H_
OLDNEW
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698