net/tools/quic/quic_simple_server_session_test.cc - Issue 1744103003: QuicSession::CreateIncomingDynamicStream now retains ownership of the created stream. No functional…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_simple_server_session_test.cc

Issue 1744103003: QuicSession::CreateIncomingDynamicStream now retains ownership of the created stream. No functional… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_simple_server_session_test.cc

diff --git a/net/tools/quic/quic_simple_server_session_test.cc b/net/tools/quic/quic_simple_server_session_test.cc

index 6dd65dad5a98ea900afcaa38cfa64566e81d66e7..e6dcdc90f44712be8a9dba9eae372dac97cd9e0c 100644

--- a/net/tools/quic/quic_simple_server_session_test.cc

+++ b/net/tools/quic/quic_simple_server_session_test.cc

@@ -282,9 +282,9 @@ TEST_P(QuicSimpleServerSessionTest, CreateEvenIncomingDynamicStream) {

}

TEST_P(QuicSimpleServerSessionTest, CreateIncomingDynamicStream) {

- std::unique_ptr<QuicSpdyStream> stream(

+ QuicSpdyStream* stream =

QuicSimpleServerSessionPeer::CreateIncomingDynamicStream(

- session_.get(), kClientDataStreamId1));

+ session_.get(), kClientDataStreamId1);

EXPECT_NE(nullptr, stream);

EXPECT_EQ(kClientDataStreamId1, stream->id());

}

« no previous file with comments | « net/tools/quic/quic_simple_server_session.cc ('k') | net/tools/quic/test_tools/quic_test_server.cc » ('j') | no next file with comments »