net/tools/quic/quic_simple_server_session.cc - Issue 1744103003: QuicSession::CreateIncomingDynamicStream now retains ownership of the created stream. No functional…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_simple_server_session.cc

Issue 1744103003: QuicSession::CreateIncomingDynamicStream now retains ownership of the created stream. No functional… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_simple_server_session.cc

diff --git a/net/tools/quic/quic_simple_server_session.cc b/net/tools/quic/quic_simple_server_session.cc

index 5a2619a03b51047aa1fc51886ca3c986710777d0..e72383a29de6551d0564c980da0df91a4b402d89 100644

--- a/net/tools/quic/quic_simple_server_session.cc

+++ b/net/tools/quic/quic_simple_server_session.cc

@@ -73,7 +73,9 @@ QuicSpdyStream* QuicSimpleServerSession::CreateIncomingDynamicStream(

return nullptr;

}

- return new QuicSimpleServerStream(id, this);

+ QuicSpdyStream* stream = new QuicSimpleServerStream(id, this);

+ ActivateStream(stream);

+ return stream;

}

QuicSimpleServerStream* QuicSimpleServerSession::CreateOutgoingDynamicStream(

« no previous file with comments | « net/tools/quic/quic_server_session_base_test.cc ('k') | net/tools/quic/quic_simple_server_session_test.cc » ('j') | no next file with comments »