Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: net/quic/quic_session.h

Issue 1744103003: QuicSession::CreateIncomingDynamicStream now retains ownership of the created stream. No functional… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/p2p/quic_p2p_session.cc ('k') | net/quic/quic_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session.h
diff --git a/net/quic/quic_session.h b/net/quic/quic_session.h
index b4d7131631ccf6901ee5bfb7ff4c39a01835adef..601edee366fa5e7b25907d8e765d1a3cf0024b3d 100644
--- a/net/quic/quic_session.h
+++ b/net/quic/quic_session.h
@@ -228,13 +228,14 @@ class NET_EXPORT_PRIVATE QuicSession : public QuicConnectionVisitorInterface {
protected:
typedef std::unordered_map<QuicStreamId, ReliableQuicStream*> StreamMap;
- // Creates a new stream, owned by the caller, to handle a peer-initiated
- // stream. Returns nullptr and does error handling if the stream can not be
- // created.
+ // Creates a new stream to handle a peer-initiated stream.
+ // Caller does not own the returned stream.
+ // Returns nullptr and does error handling if the stream can not be created.
virtual ReliableQuicStream* CreateIncomingDynamicStream(QuicStreamId id) = 0;
- // Create a new stream, owned by the caller, to handle a locally-initiated
- // stream. Returns nullptr if max streams have already been opened.
+ // Create a new stream to handle a locally-initiated stream.
+ // Caller does not own the returned stream.
+ // Returns nullptr if max streams have already been opened.
virtual ReliableQuicStream* CreateOutgoingDynamicStream(
SpdyPriority priority) = 0;
@@ -253,6 +254,7 @@ class NET_EXPORT_PRIVATE QuicSession : public QuicConnectionVisitorInterface {
// and |stream_id| is a peer-created id, then a new stream is created and
// returned. However if |stream_id| is a locally-created id and no such stream
// exists, the connection is closed.
+ // Caller does not own the returned stream.
ReliableQuicStream* GetOrCreateDynamicStream(QuicStreamId stream_id);
// Performs the work required to close |stream_id|. If |locally_reset|
« no previous file with comments | « net/quic/p2p/quic_p2p_session.cc ('k') | net/quic/quic_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698