net/quic/quic_session.cc - Issue 1744103003: QuicSession::CreateIncomingDynamicStream now retains ownership of the created stream. No functional…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_session.cc

Issue 1744103003: QuicSession::CreateIncomingDynamicStream now retains ownership of the created stream. No functional… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_session.cc

diff --git a/net/quic/quic_session.cc b/net/quic/quic_session.cc

index e3aad3f6dc5618ca7145f5ace1db7df21a5fc525..8a9b92a21cf89ce0e1fca275fd6825f823b14b20 100644

--- a/net/quic/quic_session.cc

+++ b/net/quic/quic_session.cc

@@ -691,12 +691,7 @@ ReliableQuicStream* QuicSession::GetOrCreateDynamicStream(

return nullptr;

}

- ReliableQuicStream* stream = CreateIncomingDynamicStream(stream_id);

- if (stream == nullptr) {

- return nullptr;

- }

- ActivateStream(stream);

- return stream;

+ return CreateIncomingDynamicStream(stream_id);

}

void QuicSession::set_max_open_incoming_streams(

« no previous file with comments | « net/quic/quic_session.h ('k') | net/quic/quic_session_test.cc » ('j') | no next file with comments »