Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1744073002: Remove NPAPI use in fast/frames/sandboxed-iframe-navigation-allowed.html (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NPAPI use in fast/frames/sandboxed-iframe-navigation-allowed.html BUG=493212 Committed: https://crrev.com/54dbc67049f56bab3b3ca2efb2a2e1743f8a531e Cr-Commit-Position: refs/heads/master@{#378224}

Patch Set 1 #

Patch Set 2 : Make test results slightly more sensible. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/fast/frames/resources/sandboxed-iframe-about-blank.html View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-about-blank.html View 1 1 chunk +3 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-about-blank-expected.txt View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dcheng
4 years, 9 months ago (2016-02-28 05:59:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744073002/20001
4 years, 9 months ago (2016-02-28 06:02:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-28 08:26:20 UTC) #6
Mike West
LGTM.
4 years, 9 months ago (2016-02-29 10:01:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744073002/20001
4 years, 9 months ago (2016-02-29 16:14:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 17:21:09 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 17:22:54 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/54dbc67049f56bab3b3ca2efb2a2e1743f8a531e
Cr-Commit-Position: refs/heads/master@{#378224}

Powered by Google App Engine
This is Rietveld 408576698