Fix the problem that wrong context menu shows up when right clicking a link on Mac

chrome/browser/tab_contents/render_view_context_menu.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 708 matching lines @@
   AppendDeveloperItems();
 }
 
 void RenderViewContextMenu::AppendPanelItems() {
   const Extension* extension = GetExtension();
 
   bool has_selection = !params_.selection_text.empty();
 
   if (params_.is_editable)
     AppendEditableItems();
+  // Checking link should take precedence before checking selection since on Mac
+  // right-clicking a link will also make it selected.
+  else if (params_.unfiltered_link_url.is_valid())
+    AppendLinkItems();
   else if (has_selection)

[Dmitry Titov, 2013/06/19 01:14:41]

why have an 'else' here? On normal pages we show both Link items and "Copy"...

[jianli, 2013/06/19 17:08:18]

Changed to allow both link and copy.

     AppendCopyItem();
-  else if (params_.unfiltered_link_url.is_valid())
-    AppendLinkItems();
 
   // Only add extension items from this extension.
   int index = 0;
   extension_items_.AppendExtensionItems(extension->id(),
                                         PrintableSelectionText(), &index);
 }
 
 void RenderViewContextMenu::AddMenuItem(int command_id,
                                         const string16& title) {
   menu_model_.AddItem(command_id, title);
@@ skipping 1301 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }