Index defined top-level and class member names.

Index defined top-level and class member names.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/2fa0d483ecad557700e64e9afa394cdfae22a87e

[Brian Wilkerson, 2016-02-27 18:15:11]

I don't really understand large portions of this CL, so I'll defer to Paul, but
what I did understand LGTM

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/format.dart (right):

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:1591: fbBuilder.addOffset(5,
offset_elementKinds);
It would be good to use constants for these offsets, especially given that
someone has to remember all the places to update them when they need to change.

[scheglov, 2016-02-27 23:00:44]

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/format.dart (right):

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:1591: fbBuilder.addOffset(5,
offset_elementKinds);
On 2016/02/27 18:15:10, Brian Wilkerson wrote:
> It would be good to use constants for these offsets, especially given that
> someone has to remember all the places to update them when they need to
change.

I'm sorry, I should have thought to provide more details.

The files 	format.dart and format.fbs are generated from idl.dart file.
So, these constants are specified there as:
  @Id(5)
  List<IndexSyntheticElementKind> get elementKinds;

It also does not worth to review these auto-generated files.

[scheglov, 2016-02-29 16:43:10]

Description was changed from

==========
Index defined top-level and class member names.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Index defined top-level and class member names.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/2fa0d483ecad557700e64e9afa394cdfae22a87e
==========

[scheglov, 2016-02-29 16:43:11]

Committed patchset #1 (id:1) manually as
2fa0d483ecad557700e64e9afa394cdfae22a87e (presubmit successful).

[Paul Berry, 2016-02-29 20:26:02]

lgtm

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:522: * referenced in the [PackageIndex]. 
It is an index into [uris] list.
I assume this is now an index into the [strings] list, since the [uris] list is
gone?

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:546: * referenced in the [PackageIndex]. 
It is an index into [uris] list.
Same question here.

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/index_unit.dart (right):

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:184: final int nameId;
Please document what this id refers to (I assume it's an index into
PackageIndexAssembler._strings)

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:563: *  - Call [defineName] for
name defined in the compilation unit.
s/for name/for each name/

[scheglov, 2016-02-29 20:47:44]

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/index_unit.dart (right):

https://codereview.chromium.org/1743963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:184: final int nameId;
On 2016/02/29 20:26:02, Paul Berry wrote:
> Please document what this id refers to (I assume it's an index into
> PackageIndexAssembler._strings)

Fixed in https://codereview.chromium.org/1753433002