Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/untrusted/pll_loader/nacl.scons

Issue 1743893002: PNaCl dynamic linking: Build an initial dynamically-linked newlib-based libc (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/untrusted/nacl/start.c ('k') | src/untrusted/pll_loader/pll_loader_main.cc » ('j') | tests/pnacl_dynamic_loading/nacl.scons » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/untrusted/pll_loader/nacl.scons
diff --git a/src/untrusted/pll_loader/nacl.scons b/src/untrusted/pll_loader/nacl.scons
index 2bacdd928503e74609f9c0fc3907d4e9815e86c7..1b0175506fb65855993690e96484f3b2f6996a63 100644
--- a/src/untrusted/pll_loader/nacl.scons
+++ b/src/untrusted/pll_loader/nacl.scons
@@ -9,3 +9,9 @@ if not env.Bit('bitcode'):
Return()
env.ComponentLibrary('pll_loader', ['pll_loader.cc'])
+
+# Ideally we would want to build an executable here (using
+# ComponentProgram()), but Scons makes it difficult for a nacl.scons file
+# in tests/ to refer to an executable built in src/untrusted/, because the
+# two can use different subdirectories of scons-out/.
+env.ComponentLibrary('pll_loader_main', ['pll_loader_main.cc'])
« no previous file with comments | « src/untrusted/nacl/start.c ('k') | src/untrusted/pll_loader/pll_loader_main.cc » ('j') | tests/pnacl_dynamic_loading/nacl.scons » ('J')

Powered by Google App Engine
This is Rietveld 408576698