PNaCl dynamic linking: Build an initial dynamically-linked newlib-based libc

PNaCl dynamic linking: Build an initial dynamically-linked newlib-based libc

 * Add libc_entry.c: entry-point/startup code for this libc.  This
   replaces _start() (from src/untrusted/nacl/start.c).

 * Add a pll_loader executable that is able to load and run an
   executable that's dynamically linked against a libc PLL.

   Also rename the "pll_loader" library target to "pll_loader_lib" so
   that people don't confuse it with the executable.

 * Add Scons plumbing for building the libc PLL, etc.  For now, it's
   easier to do this inside of tests/, but this logic should
   eventually move into toolchain_build/ and the PNaCl driver scripts.

 * Move the declaration of main() to start.h so that the new code can
   reuse it.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
TEST=run_pll_hello_world_test_irt

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/8d5af2ed9c63eb74c495f04b4951c0bf6ae321aa

[Mark Seaborn, 2016-02-27 01:16:27]

Description was changed from

==========
PNaCl dynamic linking: Build an initial dynamically-linked newlib-based libc

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
TEST=run_pll_hello_world_test_irt
==========

to

==========
PNaCl dynamic linking: Build an initial dynamically-linked newlib-based libc

 * Add libc_entry.c: entry-point/startup code for this libc.  This
   replaces _start() (from src/untrusted/nacl/start.c).

 * Add a pll_loader executable that is able to load and run an
   executable that's dynamically linked against a libc PLL.

 * Add Scons plumbing for building the libc PLL, etc.  For now, it's
   easier to do this inside of tests/, but this logic should
   eventually move into toolchain_build/ and the PNaCl driver scripts.

 * Move the declaration of main() to start.h so that the new code can
   reuse it.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
TEST=run_pll_hello_world_test_irt
==========

[Mark Seaborn, 2016-02-27 01:17:50]

mseaborn@chromium.org changed reviewers:
+ smklein@chromium.org

[Sean Klein, 2016-02-29 18:18:08]

lgtm

https://codereview.chromium.org/1743893002/diff/1/tests/pnacl_dynamic_loading...
File tests/pnacl_dynamic_loading/nacl.scons (right):

https://codereview.chromium.org/1743893002/diff/1/tests/pnacl_dynamic_loading...
tests/pnacl_dynamic_loading/nacl.scons:158: pll_loader = env.ComponentProgram(
So pll_loader is a library (built in src/unstrusted/pll_loader/nacl.scons), but
pll_loader is also an executable (built here).

The "pll_loader" name is overloaded -- could this version of "pll_loader" be
renamed to "pll_loader_executable", or something like that, to break ambiguity?

[Mark Seaborn, 2016-02-29 20:08:44]

https://codereview.chromium.org/1743893002/diff/1/tests/pnacl_dynamic_loading...
File tests/pnacl_dynamic_loading/nacl.scons (right):

https://codereview.chromium.org/1743893002/diff/1/tests/pnacl_dynamic_loading...
tests/pnacl_dynamic_loading/nacl.scons:158: pll_loader = env.ComponentProgram(
On 2016/02/29 18:18:07, Sean Klein wrote:
> So pll_loader is a library (built in src/unstrusted/pll_loader/nacl.scons),
but
> pll_loader is also an executable (built here).
> 
> The "pll_loader" name is overloaded -- could this version of "pll_loader" be
> renamed to "pll_loader_executable", or something like that, to break
ambiguity?

That overloading doesn't cause any technical problems because the two are in
different namespaces.  Do you mean you want a way to avoid ambiguity when
talking about these components?

I wouldn't want to call the executable "pll_loader_executable" because that's
rather verbose.

I could rename the library to "pll_loader_lib" if you want?  Or we could just
refer to it as "the PLL loader library"?

[Sean Klein, 2016-02-29 20:10:39]

https://codereview.chromium.org/1743893002/diff/1/tests/pnacl_dynamic_loading...
File tests/pnacl_dynamic_loading/nacl.scons (right):

https://codereview.chromium.org/1743893002/diff/1/tests/pnacl_dynamic_loading...
tests/pnacl_dynamic_loading/nacl.scons:158: pll_loader = env.ComponentProgram(
I know it's not a technical problem, but I wanted to avoid any readability
issues.

I would prefer the "pll_loader_lib" solution.

[Mark Seaborn, 2016-02-29 22:26:12]

https://codereview.chromium.org/1743893002/diff/1/tests/pnacl_dynamic_loading...
File tests/pnacl_dynamic_loading/nacl.scons (right):

https://codereview.chromium.org/1743893002/diff/1/tests/pnacl_dynamic_loading...
tests/pnacl_dynamic_loading/nacl.scons:158: pll_loader = env.ComponentProgram(
On 2016/02/29 20:10:39, Sean Klein wrote:
> I know it's not a technical problem, but I wanted to avoid any readability
> issues.
> 
> I would prefer the "pll_loader_lib" solution.

OK, done.

[Mark Seaborn, 2016-02-29 23:20:33]

Description was changed from

==========
PNaCl dynamic linking: Build an initial dynamically-linked newlib-based libc

 * Add libc_entry.c: entry-point/startup code for this libc.  This
   replaces _start() (from src/untrusted/nacl/start.c).

 * Add a pll_loader executable that is able to load and run an
   executable that's dynamically linked against a libc PLL.

 * Add Scons plumbing for building the libc PLL, etc.  For now, it's
   easier to do this inside of tests/, but this logic should
   eventually move into toolchain_build/ and the PNaCl driver scripts.

 * Move the declaration of main() to start.h so that the new code can
   reuse it.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
TEST=run_pll_hello_world_test_irt
==========

to

==========
PNaCl dynamic linking: Build an initial dynamically-linked newlib-based libc

 * Add libc_entry.c: entry-point/startup code for this libc.  This
   replaces _start() (from src/untrusted/nacl/start.c).

 * Add a pll_loader executable that is able to load and run an
   executable that's dynamically linked against a libc PLL.

   Also rename the "pll_loader" library target to "pll_loader_lib" so
   that people don't confuse it with the executable.

 * Add Scons plumbing for building the libc PLL, etc.  For now, it's
   easier to do this inside of tests/, but this logic should
   eventually move into toolchain_build/ and the PNaCl driver scripts.

 * Move the declaration of main() to start.h so that the new code can
   reuse it.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
TEST=run_pll_hello_world_test_irt
==========

[Mark Seaborn, 2016-02-29 23:21:42]

The CQ bit was checked by mseaborn@chromium.org

[Mark Seaborn, 2016-02-29 23:21:42]

The patchset sent to the CQ was uploaded after l-g-t-m from smklein@chromium.org
Link to the patchset: https://codereview.chromium.org/1743893002/#ps20001
(title: "Review: rename library")

[commit-bot: I haz the power, 2016-02-29 23:21:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743893002/20001

[commit-bot: I haz the power, 2016-02-29 23:23:25]

Description was changed from

==========
PNaCl dynamic linking: Build an initial dynamically-linked newlib-based libc

 * Add libc_entry.c: entry-point/startup code for this libc.  This
   replaces _start() (from src/untrusted/nacl/start.c).

 * Add a pll_loader executable that is able to load and run an
   executable that's dynamically linked against a libc PLL.

   Also rename the "pll_loader" library target to "pll_loader_lib" so
   that people don't confuse it with the executable.

 * Add Scons plumbing for building the libc PLL, etc.  For now, it's
   easier to do this inside of tests/, but this logic should
   eventually move into toolchain_build/ and the PNaCl driver scripts.

 * Move the declaration of main() to start.h so that the new code can
   reuse it.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
TEST=run_pll_hello_world_test_irt
==========

to

==========
PNaCl dynamic linking: Build an initial dynamically-linked newlib-based libc

 * Add libc_entry.c: entry-point/startup code for this libc.  This
   replaces _start() (from src/untrusted/nacl/start.c).

 * Add a pll_loader executable that is able to load and run an
   executable that's dynamically linked against a libc PLL.

   Also rename the "pll_loader" library target to "pll_loader_lib" so
   that people don't confuse it with the executable.

 * Add Scons plumbing for building the libc PLL, etc.  For now, it's
   easier to do this inside of tests/, but this logic should
   eventually move into toolchain_build/ and the PNaCl driver scripts.

 * Move the declaration of main() to start.h so that the new code can
   reuse it.

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
TEST=run_pll_hello_world_test_irt

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/8d5af2ed9...
==========

[commit-bot: I haz the power, 2016-02-29 23:23:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/8d5af2ed9...