Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1743813002: Revert of [cherrypick] Fix computation of runtime for throttled tasks (Closed)

Created:
4 years, 10 months ago by jaydasika
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Revert of [cherrypick] Fix computation of runtime for throttled tasks (patchset #2 id:20001 of https://codereview.chromium.org/1730153005/ ) Reason for revert: The reason for reverting is: Speculative revert for Compile failure on Win, Mac & Precise 64 Beta Bots (crbug.com/590286) Original issue's description: > [cherrypick] Fix computation of runtime for throttled tasks > > The computation of the delayed task runtime was computing the (virtual) > TimeDomain's now + delay. That doesn't take into account the skew > between the real time and the virtual time, which meant timers could > run sooner than expected for background tabs. Timers associated with > foreground tabs are unaffected. > > This patch makes the computation of delayed runtime the responsibility > of the TimeDomain and introduces a ThrottledTimeDomain which computes > the delayed runtime as realtime + delay. > > This means timers will no longer run sooner than expected. Under normal > circumstancs this only timers whose delay modulo 1000ms is less than 100 > ms are less likely to be affected. Timers whose whose delay modulo > 1000ms is greater than 900 are highly likely to be affected (there's a > good chance their delay was too small before). > > BUG=587074 > > Review URL: https://codereview.chromium.org/1718233002 > > Cr-Commit-Position: refs/heads/master@{#376993} > (cherry picked from commit b56bbe4ce3e7276a130a00d83cf00e5672cd6be1) > > R=skyostil@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/fd563254490ae93382cb88a1e9a1c1e54815c97b TBR=skyostil@chromium.org,alexclarke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -135 lines) Patch
M components/scheduler/base/real_time_domain.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/scheduler/base/real_time_domain.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/scheduler/base/task_queue_impl.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M components/scheduler/base/time_domain.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/scheduler/base/time_domain_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/scheduler/base/virtual_time_domain.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/scheduler/base/virtual_time_domain.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D components/scheduler/renderer/throttled_time_domain.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/scheduler/renderer/throttled_time_domain.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M components/scheduler/renderer/throttling_helper.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/scheduler/renderer/throttling_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/scheduler/renderer/throttling_helper_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M components/scheduler/scheduler.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jaydasika
Created Revert of [cherrypick] Fix computation of runtime for throttled tasks
4 years, 10 months ago (2016-02-26 23:33:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743813002/1
4 years, 10 months ago (2016-02-26 23:41:12 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 23:49:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698