content/test/weburl_loader_mock_factory.h - Issue 1743783002: Use WeakPtr and do not use pointer equality in WebURLLoaderMockFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/weburl_loader_mock_factory.h

Issue 1743783002: Use WeakPtr and do not use pointer equality in WebURLLoaderMockFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Loader_URLTestHelpers

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/weburl_loader_mock_factory.h

diff --git a/content/test/weburl_loader_mock_factory.h b/content/test/weburl_loader_mock_factory.h

index c326d64be0841d2f0072770c382e3c1536bebf5a..10cb4141ddfbcfe5049163b709f9b0d551f9b163 100644

--- a/content/test/weburl_loader_mock_factory.h

+++ b/content/test/weburl_loader_mock_factory.h

@@ -9,6 +9,7 @@

#include "base/files/file_path.h"

#include "base/macros.h"

+#include "base/memory/weak_ptr.h"

#include "third_party/WebKit/public/platform/WebURL.h"

#include "third_party/WebKit/public/platform/WebURLError.h"

#include "third_party/WebKit/public/platform/WebURLRequest.h"

@@ -95,7 +96,7 @@ class WebURLLoaderMockFactory {

blink::WebData* data);

// Checks if the loader is pending. Otherwise, it may have been deleted.

- bool IsPending(WebURLLoaderMock* loader);

+ bool IsPending(base::WeakPtr<WebURLLoaderMock> loader);

// Reads |m_filePath| and puts its content in |data|.

// Returns true if it successfully read the file.

« no previous file with comments | « content/test/weburl_loader_mock.cc ('k') | content/test/weburl_loader_mock_factory.cc » ('j') | no next file with comments »