Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: content/test/weburl_loader_mock.h

Issue 1743783002: Use WeakPtr and do not use pointer equality in WebURLLoaderMockFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Loader_URLTestHelpers
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/weburl_loader_mock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/weburl_loader_mock.h
diff --git a/content/test/weburl_loader_mock.h b/content/test/weburl_loader_mock.h
index 81a8e187bd9aff0cc648f366b23ecf3b96080716..465d6282725c9b037c47f5635df9b025f6947f67 100644
--- a/content/test/weburl_loader_mock.h
+++ b/content/test/weburl_loader_mock.h
@@ -54,9 +54,12 @@ class WebURLLoaderMock : public blink::WebURLLoader {
void setDefersLoading(bool defer) override;
bool isDeferred() { return is_deferred_; }
+ bool isCancelled() { return !client_; }
jam 2016/02/29 16:41:09 nit: these two should be is_deferred() and is_canc
hiroshige 2016/02/29 21:21:55 Done.
void setLoadingTaskRunner(blink::WebTaskRunner*) override;
+ base::WeakPtr<WebURLLoaderMock> GetWeakPtr();
+
private:
WebURLLoaderMockFactory* factory_;
blink::WebURLLoaderClient* client_;
« no previous file with comments | « no previous file | content/test/weburl_loader_mock.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698