WebAssembly: skip unknown sections, add names

src/wasm/wasm-module.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_WASM_MODULE_H_
 #define V8_WASM_MODULE_H_
 
 #include "src/wasm/wasm-opcodes.h"
 #include "src/wasm/wasm-result.h"
 
 #include "src/api.h"
 #include "src/handles.h"
 
 namespace v8 {
 namespace internal {
 
 namespace compiler {
 class CallDescriptor;
 }
 
 namespace wasm {
 const size_t kMaxModuleSize = 1024 * 1024 * 1024;
 const size_t kMaxFunctionSize = 128 * 1024;
 const size_t kMaxStringSize = 256;
 
+// WebAssembly sections are named as strings in the binary format, but
+// internally V8 uses an enum to handle them.
+//
+// Entries have the form F(enumerator, string).
+#define FOR_EACH_WASM_SECTION_TYPE(F)      \
+  F(kDeclMemory, "memory")                 \
+  F(kDeclSignatures, "signatures")         \
+  F(kDeclFunctions, "functions")           \
+  F(kDeclGlobals, "globals")               \
+  F(kDeclDataSegments, "data_segments")    \
+  F(kDeclFunctionTable, "function_tables") \

[titzer, 2016/02/26 22:54:17]

function_table

[JF, 2016/02/26 23:42:41]

Done.

+  F(kDeclEnd, "end")                       \
+  F(kDeclStartFunction, "start_function")  \
+  F(kDeclImportTable, "import_table")
+
 enum WasmSectionDeclCode {
-  kDeclMemory = 0x00,
-  kDeclSignatures = 0x01,
-  kDeclFunctions = 0x02,
-  kDeclGlobals = 0x03,
-  kDeclDataSegments = 0x04,
-  kDeclFunctionTable = 0x05,
-  kDeclEnd = 0x06,
-  kDeclStartFunction = 0x07,
-  kDeclImportTable = 0x08,
-  kDeclWLL = 0x11,
+#define F(enumerator, string) enumerator,
+  FOR_EACH_WASM_SECTION_TYPE(F)
+#undef F
+      kMaxModuleSectionCode
 };
 
-static const int kMaxModuleSectionCode = 0x11;
-
 enum WasmFunctionDeclBit {
   kDeclFunctionName = 0x01,
   kDeclFunctionImport = 0x02,
   kDeclFunctionLocals = 0x04,
   kDeclFunctionExport = 0x08
 };
 
 // Constants for fixed-size elements within a module.
 static const size_t kDeclMemorySize = 3;
 static const size_t kDeclGlobalSize = 6;
@@ skipping 185 matching lines @@
 
 // For testing. Decode, verify, and run the last exported function in the
 // given decoded module.
 int32_t CompileAndRunWasmModule(Isolate* isolate, WasmModule* module);
 
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_WASM_MODULE_H_