WebAssembly: skip unknown sections, add names

WebAssembly: skip unknown sections, add names

Sets the code up so it'll be easier to have section names as strings instead of
hard-coded numbers. Using strings will require synchronizing with sexpr-wasm.

Mostly NFC (besides now skipping *all* unknown sections).

R=titzer@chromium.org

Committed: https://crrev.com/df269e6e542fce2790db4e43553a0007dd6648e0
Cr-Commit-Position: refs/heads/master@{#34464}

[titzer, 2016-02-26 22:54:17]

https://codereview.chromium.org/1743773002/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/1743773002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:69: for (uint32_t section_bytes =
consume_u32v(&length, "globals count");
s/globals count/section size/

https://codereview.chromium.org/1743773002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:72: (void)consume_u8("unknown section byte");
You can just consume the length and then increment the pc_ (maybe add a method
to decoder.h)

https://codereview.chromium.org/1743773002/diff/1/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/1743773002/diff/1/src/wasm/wasm-module.h#newc...
src/wasm/wasm-module.h:36: F(kDeclFunctionTable, "function_tables") \
function_table

[JF, 2016-02-26 23:42:41]

https://codereview.chromium.org/1743773002/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/1743773002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:69: for (uint32_t section_bytes =
consume_u32v(&length, "globals count");
On 2016/02/26 22:54:17, titzer wrote:
> s/globals count/section size/

Done.

https://codereview.chromium.org/1743773002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:72: (void)consume_u8("unknown section byte");
On 2016/02/26 22:54:17, titzer wrote:
> You can just consume the length and then increment the pc_ (maybe add a method
> to decoder.h)

Done.

https://codereview.chromium.org/1743773002/diff/1/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/1743773002/diff/1/src/wasm/wasm-module.h#newc...
src/wasm/wasm-module.h:36: F(kDeclFunctionTable, "function_tables") \
On 2016/02/26 22:54:17, titzer wrote:
> function_table

Done.

[titzer, 2016-02-26 23:48:52]

lgtm other than one comment

https://codereview.chromium.org/1743773002/diff/40001/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/1743773002/diff/40001/src/wasm/module-decoder...
src/wasm/module-decoder.cc:62: while (pc_ < limit_ && !failed()) {
You don't need the extra condition because failing sets limit_ to start_.

[JF, 2016-02-26 23:52:03]

The CQ bit was checked by jfb@chromium.org

[JF, 2016-02-26 23:52:04]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1743773002/#ps60001
(title: "Remove extra check.")

[commit-bot: I haz the power, 2016-02-26 23:52:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743773002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743773002/60001

[commit-bot: I haz the power, 2016-02-26 23:54:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 23:54:49]

Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/3576)
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/3454)

[JF, 2016-02-26 23:59:24]

The CQ bit was checked by jfb@chromium.org

[JF, 2016-02-26 23:59:25]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1743773002/#ps80001
(title: "MSVC warning.")

[commit-bot: I haz the power, 2016-02-26 23:59:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743773002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743773002/80001

[commit-bot: I haz the power, 2016-02-27 00:32:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-27 00:32:08]

Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/3455)
  v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[JF, 2016-02-27 01:27:17]

The CQ bit was checked by jfb@chromium.org

[JF, 2016-02-27 01:27:18]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1743773002/#ps100001
(title: "Hack to see why Windows is sad.")

[commit-bot: I haz the power, 2016-02-27 01:27:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743773002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743773002/100001

[JF, 2016-02-27 19:52:54]

The CQ bit was checked by jfb@chromium.org

[JF, 2016-02-27 19:52:54]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1743773002/#ps180001
(title: "Put back default, maybe appease Windows?")

[commit-bot: I haz the power, 2016-02-27 19:52:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743773002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743773002/180001

[JF, 2016-02-27 19:52:58]

The CQ bit was unchecked by jfb@chromium.org

[JF, 2016-02-29 16:14:34]

The CQ bit was checked by jfb@chromium.org

[JF, 2016-02-29 16:14:34]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1743773002/#ps260001
(title: "Drop size_t, it makes Windows sad, fix range later")

[commit-bot: I haz the power, 2016-02-29 16:14:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743773002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743773002/260001

[commit-bot: I haz the power, 2016-02-29 16:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 16:17:18]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/2093)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/14488)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[JF, 2016-02-29 16:39:47]

The CQ bit was checked by jfb@chromium.org

[JF, 2016-02-29 16:39:48]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1743773002/#ps280001
(title: "Rebase & fix API, it changed")

[commit-bot: I haz the power, 2016-02-29 16:39:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743773002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743773002/280001

[commit-bot: I haz the power, 2016-02-29 16:45:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 16:45:16]

Try jobs failed on following builders:
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/2093)

[JF, 2016-03-03 16:37:01]

The CQ bit was checked by jfb@chromium.org

[JF, 2016-03-03 16:37:02]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1743773002/#ps340001
(title: "Fix limit type")

[commit-bot: I haz the power, 2016-03-03 16:37:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743773002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743773002/340001

[commit-bot: I haz the power, 2016-03-03 16:52:18]

Committed patchset #18 (id:340001)

[commit-bot: I haz the power, 2016-03-03 16:53:25]

Description was changed from

==========
WebAssembly: skip unknown sections, add names

Sets the code up so it'll be easier to have section names as strings instead of
hard-coded numbers. Using strings will require synchronizing with sexpr-wasm.

Mostly NFC (besides now skipping *all* unknown sections).

R=titzer@chromium.org
==========

to

==========
WebAssembly: skip unknown sections, add names

Sets the code up so it'll be easier to have section names as strings instead of
hard-coded numbers. Using strings will require synchronizing with sexpr-wasm.

Mostly NFC (besides now skipping *all* unknown sections).

R=titzer@chromium.org

Committed: https://crrev.com/df269e6e542fce2790db4e43553a0007dd6648e0
Cr-Commit-Position: refs/heads/master@{#34464}
==========

[commit-bot: I haz the power, 2016-03-03 16:53:26]

Patchset 18 (id:??) landed as
https://crrev.com/df269e6e542fce2790db4e43553a0007dd6648e0
Cr-Commit-Position: refs/heads/master@{#34464}