Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1743713002: Generate a ".fbs" file representing the summary format. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate a ".fbs" file representing the summary format. This file can be consumed by standard flatbuffer tools, allowing summaries to be consumed from other languages. For example, a summary file can now be converted to JSON using: flatc -o $outputDirectory -t \ pkg/analyzer/lib/src/summary/format.fbs -- $inputFile R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e399f0f5a7a9fe6f282fa0a8626618406b264d4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+912 lines, -1100 lines) Patch
A + pkg/analyzer/lib/src/summary/format.fbs View 19 chunks +763 lines, -1050 lines 0 comments Download
M pkg/analyzer/tool/summary/check_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 5 chunks +148 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-26 18:35:57 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-26 18:40:09 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-26 18:53:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e399f0f5a7a9fe6f282fa0a8626618406b264d4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698