Implemented new channel switcher UI.

chromeos/dbus/update_engine_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_UPDATE_ENGINE_CLIENT_H_
 #define CHROMEOS_DBUS_UPDATE_ENGINE_CLIENT_H_
 
 #include "base/callback.h"
 #include "base/observer_list.h"
 #include "chromeos/chromeos_export.h"
 #include "chromeos/dbus/dbus_client_implementation_type.h"
 
 #include <string>
 
 namespace dbus {
 class Bus;
-}  // namespace
+}
 
 namespace chromeos {
 
 // UpdateEngineClient is used to communicate with the update engine.
 class CHROMEOS_EXPORT UpdateEngineClient {
  public:
   // Edges for state machine
   //    IDLE->CHECKING_FOR_UPDATE
   //    CHECKING_FOR_UPDATE->IDLE
   //    CHECKING_FOR_UPDATE->UPDATE_AVAILABLE
@@ skipping 52 matching lines @@
   // Called once RequestUpdateCheck() is complete. Takes one parameter:
   // - UpdateCheckResult: the result of the update check.
   typedef base::Callback<void(UpdateCheckResult)> UpdateCheckCallback;
 
   // Requests an update check and calls |callback| when completed.
   virtual void RequestUpdateCheck(const UpdateCheckCallback& callback) = 0;
 
   // Reboots if update has been performed.
   virtual void RebootAfterUpdate() = 0;
 
+  // DEPRECATED: Use SetChannel instead.
   // Requests to set the release track (channel). |track| should look like
   // "beta-channel" or "dev-channel".
   virtual void SetReleaseTrack(const std::string& track) = 0;
 
   // Called once GetReleaseTrack() is complete. Takes one parameter;
   // - string: the release track name like "beta-channel".
   typedef base::Callback<void(const std::string&)> GetReleaseTrackCallback;
 
+  // Called once GetChannel() is complete. Takes one parameter;
+  // - string: the channel name like "beta-channel".
+  typedef base::Callback<void(const std::string&)> GetChannelCallback;

[satorux1, 2013/06/24 17:21:12]

Please add a parameter name:

typedef base::Callback<void(const std::string& channel_name)>

[ygorshenin1, 2013/06/24 17:50:35]

Done.

+
+  // DEPRECATED: Use GetChannel() instead.
   // Requests to get the release track and calls |callback| with the
   // release track (channel). On error, calls |callback| with an empty
   // string.
   virtual void GetReleaseTrack(const GetReleaseTrackCallback& callback) = 0;
 
   // Returns the last status the object received from the update engine.
   //
   // Ideally, the D-Bus client should be state-less, but there are clients
   // that need this information.
   virtual Status GetLastStatus() = 0;
 
+  // Changes the current channel of the device to the target
+  // channel. If the target channel is a less stable channel than the
+  // current channel, then the channel change happens immediately (at
+  // the next update check).  If the target channel is a more stable
+  // channel, then if |is_powerwash_allowed| is set to true, then also
+  // the change happens immediately but with a powerwash if
+  // required. Otherwise, the change takes effect eventually (when the
+  // version on the target channel goes above the version number of
+  // what the device currently has). |target_channel| should look like
+  // "dev-channel", "beta-channel" or "stable-channel".
+  virtual void SetChannel(const std::string& target_channel,
+                          bool is_powerwash_allowed) = 0;

[satorux1, 2013/06/24 17:21:12]

boolean parameters like this often make callers hard to read:

  SetChannel(channel, true);  // true of what?

You might want to define an enum like POWERWASH_NONE and POWERWASH_ALLOWED

However, looking at the caller, this parameter comes from
VersionUpdaterCros::SetChannel(), which also takes a boolean parameter. Then,
introducing an enum just for this function wouldn't make sense...

[ygorshenin1, 2013/06/24 17:50:35]

We're planning to introduce an enum instead of strings for channel names and,
possibly, symbolic constants instead of booleans. But as we're in hurry, this
will be done in a separate CL.

On 2013/06/24 17:21:12, satorux1 wrote:

+
+  // If |get_current_channel| is set to true, calls |callback| with
+  // the name of the channel that the device is currently
+  // on. Otherwise, it calls it with the name of the channel the
+  // device is supposed to be (in case of a pending channel
+  // change). On error, calls |callback| with an empty string.
+  virtual void GetChannel(bool get_current_channel,
+                          const GetChannelCallback& callback) = 0;
+
   // Returns an empty UpdateCheckCallback that does nothing.
   static UpdateCheckCallback EmptyUpdateCheckCallback();
 
   // Creates the instance.
   static UpdateEngineClient* Create(DBusClientImplementationType type,
                                     dbus::Bus* bus);
 
  protected:
   // Create() should be used instead.
   UpdateEngineClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(UpdateEngineClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_UPDATE_ENGINE_CLIENT_H_