chrome/browser/resources/help/channel_change_page.html - Issue 17437004: Implemented new channel switcher UI.

Side by Side Diff: chrome/browser/resources/help/channel_change_page.html

Issue 17437004: Implemented new channel switcher UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/resources/help/channel_change_page.css ('k') | chrome/browser/resources/help/channel_change_page.js » ('j') | chrome/browser/resources/help/channel_change_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <div id="channel-change-page" class="page">

	2 <div class="close-button"></div>

	3 <h1 i18n-content="channelChangePageTitle"></h1>

	4 <div class="content-area">

	5 <div class="channel-change-page-channel">

	6 <input id="stable" type="radio" name="channel" value="stable-channel">
	James Hawkins 2013/06/24 18:13:12 "stable" as an ID is kinda dangerous (it may confl "stable" as an ID is kinda dangerous (it may conflict w/ IDs from other components). I suggest making it more unique and specific to this component (same for similarly-named IDs here). ygorshenin1 2013/06/24 18:35:31 Done. Show quoted text On 2013/06/24 18:13:12, James Hawkins wrote: > "stable" as an ID is kinda dangerous (it may conflict w/ IDs from other > components). I suggest making it more unique and specific to this component > (same for similarly-named IDs here). Done.
	7 <label for="stable" i18n-content="stable"></label>

	8 </div>

	9 <div class="channel-change-page-channel">

	10 <input id="beta" type="radio" name="channel" value="beta-channel">

	11 <label for="beta" i18n-content="beta"></label>

	12 </div>

	13 <div class="channel-change-page-channel">

	14 <input id="dev" type="radio" name="channel" value="dev-channel">

	15 <label for="dev" i18n-content="dev"></label>

	16 </div>

	17 </div>

	18 <div class="content-area">

	19 <div class="show-when-selected-channel-requires-powerwash">
	James Hawkins 2013/06/24 18:13:12 Why is this a class instead of an ID? It appears Why is this a class instead of an ID? It appears to only be used once. ygorshenin1 2013/06/24 18:35:31 channel-change-page-powerwash-button also is visib channel-change-page-powerwash-button also is visible iff selected-channel-requires-powerwash class is set. Also for uniform and simple UI transformations. On 2013/06/24 18:13:12, James Hawkins wrote: Show quoted text > Why is this a class instead of an ID? It appears to only be used once.
	20 <h2 i18n-content="channelChangePagePowerwashTitle"></h2>

	21 <div i18n-content="channelChangePagePowerwashMessage"></div>

	22 </div>

	23 <div class="show-when-selected-channel-requires-delayed-update">

	24 <h2 i18n-content="channelChangePageDelayedChangeTitle"></h2>

	25 <div i18n-content="channelChangePageDelayedChangeMessage"></div>

	26 </div>

	27 <div class="show-when-selected-channel-unstable">

	28 <h2 i18n-content="channelChangePageUnstableTitle"></h2>

	29 <div i18n-content="channelChangePageUnstableMessage"></div>

	30 </div>

	31 </div>

	32 <div class="action-area">

	33 <div class="button-strip">

	34 <button id="channel-change-page-powerwash-button"

	35 class="show-when-selected-channel-requires-powerwash"

	36 i18n-content="channelChangePagePowerwashButton"></button>
	James Hawkins 2013/06/24 18:13:12 nit: Closing tag of wrapped element must be on a n nit: Closing tag of wrapped element must be on a new line. Same for other cases. ygorshenin1 2013/06/24 18:35:31 Done. Show quoted text On 2013/06/24 18:13:12, James Hawkins wrote: > nit: Closing tag of wrapped element must be on a new line. Same for other > cases. Done.
	37 <button id="channel-change-page-change-button"

	38 class="show-when-selected-channel-requires-delayed-update

	39 show-when-selected-channel-good

	40 show-when-selected-channel-unstable"

	41 i18n-content="channelChangePageChangeButton"></button>

	42 <button id="channel-change-page-cancel-button"

	43 class="default-button"

	44 i18n-content="channelChangePageCancelButton"></button>

	45 </div>

	46 </div>

	47 </div>

OLD	NEW