Stop prefixing the library name to type names when reporting a type error with

Stop prefixing the library name to type names when reporting a type error with
identical names. The library name is not always helpful, and the prefix confuses
users when the types are function types.
Instead, enumerate all appearing types with their URIs.
This should help debug issue #27229258.

R=srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/a8d71a461d82a54a5d9a2a7feac4faa74981aafc

[regis, 2016-02-26 17:32:24]

regis@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2016-02-26 17:54:16]

https://codereview.chromium.org/1743653002/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/1743653002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:528: String& dst_type_name =
String::Handle(dst_type.UserVisibleName());
const String

https://codereview.chromium.org/1743653002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:533: }
I would still report something special when both src_type and dts_type have the
same name

[regis, 2016-02-26 22:16:22]

Description was changed from

==========
Stop prefixing the library name to type names when reporting a type error with
identical names. The library name is not always helpful, and the prefix confuses
users when the types are function types.
==========

to

==========
Stop prefixing the library name to type names when reporting a type error with
identical names. The library name is not always helpful, and the prefix confuses
users when the types are function types.
Instead, enumerate all appearing types with their URIs.
This should help debug issue #27229258.
==========

[regis, 2016-02-26 22:18:00]

PTAL

[srdjan, 2016-02-26 22:54:20]

lgtm

[regis, 2016-02-26 23:12:13]

Description was changed from

==========
Stop prefixing the library name to type names when reporting a type error with
identical names. The library name is not always helpful, and the prefix confuses
users when the types are function types.
Instead, enumerate all appearing types with their URIs.
This should help debug issue #27229258.
==========

to

==========
Stop prefixing the library name to type names when reporting a type error with
identical names. The library name is not always helpful, and the prefix confuses
users when the types are function types.
Instead, enumerate all appearing types with their URIs.
This should help debug issue #27229258.

R=srdjan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a8d71a461d82a54a5d9a2a7feac4faa74981aafc
==========

[regis, 2016-02-26 23:12:15]

Committed patchset #2 (id:20001) manually as
a8d71a461d82a54a5d9a2a7feac4faa74981aafc (presubmit successful).