Evict CachedResources if they are cancelled due to last client being removed.

Evict CachedResources if they are cancelled due to last client being removed.

Currently, it's possible for a CachedResource to be cancelled when the last
client is removed, but to remain in the cache in an inconsistent state, such
that future requested will hang. Evict the resource from the cache as part of
its cancellation.

Also, don't start the cancel timer if a load isn't in progress.

BUG=251181
TEST=CachedImageTest.CancelOnDetach

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152686

[Nate Chapin, 2013-06-18 23:12:10]

I wasn't able to figure out how to reduce the webpage in
https://code.google.com/p/chromium/issues/detail?id=251181 to a layout test, so
I made a unit test instead.

[abarth-chromium, 2013-06-18 23:15:26]

lgtm

https://codereview.chromium.org/17436003/diff/1/Source/core/loader/cache/Cach...
File Source/core/loader/cache/CachedResource.cpp (right):

https://codereview.chromium.org/17436003/diff/1/Source/core/loader/cache/Cach...
Source/core/loader/cache/CachedResource.cpp:165: m_cancelTimer.stop();
This doesn't happen automatically when the timer is destroyed?

[Nate Chapin, 2013-06-18 23:24:48]

https://codereview.chromium.org/17436003/diff/1/Source/core/loader/cache/Cach...
File Source/core/loader/cache/CachedResource.cpp (right):

https://codereview.chromium.org/17436003/diff/1/Source/core/loader/cache/Cach...
Source/core/loader/cache/CachedResource.cpp:165: m_cancelTimer.stop();
On 2013/06/18 23:15:26, abarth wrote:
> This doesn't happen automatically when the timer is destroyed?

Derp, I didn't look in Timer's base class :(

Will remove before landing.

[commit-bot: I haz the power, 2013-06-18 23:26:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/17436003/6001

[commit-bot: I haz the power, 2013-06-19 02:08:01]

Change committed as 152686

[scottmg, 2013-06-21 04:31:11]

On 2013/06/19 02:08:01, I haz the power (commit-bot) wrote:
> Change committed as 152686

This test is hitting test.com/cancelTest.html through the network when running
in webkit_unit_tests.

I'm trying to land a dcheck to prevent this in the future
(https://codereview.chromium.org/17229012/ and
https://codereview.chromium.org/16831015/), but would you mind taking a
look/disabling/reverting this one?

[Nate Chapin, 2013-06-21 16:09:35]

On 2013/06/21 04:31:11, scottmg wrote:
> On 2013/06/19 02:08:01, I haz the power (commit-bot) wrote:
> > Change committed as 152686
> 
> This test is hitting test.com/cancelTest.html through the network when running
> in webkit_unit_tests.
> 
> I'm trying to land a dcheck to prevent this in the future
> (https://codereview.chromium.org/17229012/ and
> https://codereview.chromium.org/16831015/), but would you mind taking a
> look/disabling/reverting this one?

Sure, will make it stop one way or the other today.