Enable Accelerated Video Decode in Linux

content/browser/gpu/gpu_data_manager_impl_private.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/gpu/gpu_data_manager_impl_private.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
+#include "base/cpu.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/stringprintf.h"
 #include "base/sys_info.h"
 #include "base/trace_event/trace_event.h"
 #include "base/version.h"
 #include "build/build_config.h"
@@ skipping 220 matching lines @@
     if (gpu::CollectGpuID(&vendor_id, &device_id) == gpu::kCollectInfoSuccess) {
       gpu_changed = manager->UpdateActiveGpu(vendor_id, device_id);
     }
   }
 
   if (display_changed || gpu_changed)
     manager->HandleGpuSwitch();
 }
 #endif  // OS_MACOSX
 
+#if defined(OS_LINUX)
+bool ShouldEnableAcceleratedVideoDecodeInLinux() {
+#if defined(OS_CHROMEOS)
+  return true;
+#endif  // defined(OS_CHROMEOS)
+
+// Allow only latest Intel architecture. +IvyBridge
+#if defined(ARCH_CPU_X86_FAMILY)
+  struct CPU {
+    int family;  // family of the processor
+    int model;   // model of processor
+  };

[Avi (use Gerrit), 2016/02/26 17:57:40]

put operator< here and use std::tie...

struct CPU {
  int family;  // family of the processor
  int model;   // model of processor

  bool operator<(const CPU& other) const {
    return std::tie(family, model) < std::tie(other.family, other.model);
  }
};

[dshwang, 2016/02/26 18:11:35]

chromium code style prohibits from adding any methods except for initialization
logic.
https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes

Can I add operator< method to struct?

[Avi (use Gerrit), 2016/02/26 18:33:28]

Hm.

OK, leave it in the binary_search, but use std::tie there.

+  const CPU kIntelWhitelistTable[] = {
+      // http://instlatx64.atw.hu/ for CPUID
+      {0x06, 0x3A},  // IvyBridge
+      {0x06, 0x3C},  // Haswell
+      {0x06, 0x3D},  // Broadwell
+      {0x06, 0x3E},  // IvyBridge
+      {0x06, 0x3F},  // Haswell
+      {0x06, 0x45},  // Haswell
+      {0x06, 0x46},  // Haswell
+      {0x06, 0x47},  // Broadwell-H
+      {0x06, 0x4C},  // Braswell
+      {0x06, 0x4E},  // Skylake
+      {0x06, 0x56},  // Broadwell-DE
+  };
+
+  base::CPU cpuid;
+  const CPU search_elem = {cpuid.family(), cpuid.model()};
+  bool allowed =
+      std::binary_search(kIntelWhitelistTable,
+                         kIntelWhitelistTable + arraysize(kIntelWhitelistTable),
+                         search_elem, [](const CPU& a, const CPU& b) {
+                           return a.family < b.family ||
+                                  (a.family == b.family && a.model < b.model);

[Avi (use Gerrit), 2016/02/26 17:57:40]

... and not in here.

+                         });
+  return allowed;
+#endif  // defined(ARCH_CPU_X86_FAMILY)
+
+  return false;
+}
+#endif
+
 // Block all domains' use of 3D APIs for this many milliseconds if
 // approaching a threshold where system stability might be compromised.
 const int64_t kBlockAllDomainsMs = 10000;
 const int kNumResetsWithinDuration = 1;
 
 // Enums for UMA histograms.
 enum BlockStatusHistogram {
   BLOCK_STATUS_NOT_BLOCKED,
   BLOCK_STATUS_SPECIFIC_DOMAIN_BLOCKED,
   BLOCK_STATUS_ALL_DOMAINS_BLOCKED,
@@ skipping 687 matching lines @@
       "DisableAcceleratedVideoDecode");
   if (command_line->HasSwitch(switches::kDisableAcceleratedVideoDecode)) {
     // It was already disabled on the command line.
     return false;
   }
   if (IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_ACCELERATED_VIDEO_DECODE))
     return true;
   if (group_name == "Disabled")
     return true;
 
+#if defined(OS_LINUX)
+  if (!ShouldEnableAcceleratedVideoDecodeInLinux())
+    return true;
+#endif
+
   // Accelerated decode is never available with --disable-gpu.
   return command_line->HasSwitch(switches::kDisableGpu);
 }
 
 void GpuDataManagerImplPrivate::GetDisabledExtensions(
     std::string* disabled_extensions) const {
   DCHECK(disabled_extensions);
   *disabled_extensions = disabled_extensions_;
 }
 
@@ skipping 270 matching lines @@
   gpu_info_.context_info_state = gpu::kCollectInfoFatalFailure;
 #if defined(OS_WIN)
   gpu_info_.dx_diagnostics_info_state = gpu::kCollectInfoFatalFailure;
 #endif
   complete_gpu_info_already_requested_ = true;
   // Some observers might be waiting.
   NotifyGpuInfoUpdate();
 }
 
 }  // namespace content