Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1743543002: [api] Move slow-path work behind fast path in InstantiateObject (Closed)

Created:
4 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Move slow-path work behind fast path in InstantiateObject BUG= R=bmeurer@chromium.org Committed: https://crrev.com/bd39edcdfc6f6d7e0db5b798b85ecd8036f7460b Cr-Commit-Position: refs/heads/master@{#34326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/api-natives.cc View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 10 months ago (2016-02-26 12:28:17 UTC) #1
Benedikt Meurer
Nice, LGTM.
4 years, 10 months ago (2016-02-26 12:37:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743543002/1
4 years, 10 months ago (2016-02-26 12:40:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 12:53:56 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 12:54:26 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bd39edcdfc6f6d7e0db5b798b85ecd8036f7460b
Cr-Commit-Position: refs/heads/master@{#34326}

Powered by Google App Engine
This is Rietveld 408576698