Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 174353003: Use the correct value offset for Float64x2 on ARM (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/lib/typed_data/float64x2_functional_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 3078 matching lines...) Expand 10 before | Expand all | Expand 10 after
3089 DRegister value_even = EvenDRegisterOf(value); 3089 DRegister value_even = EvenDRegisterOf(value);
3090 DRegister value_odd = OddDRegisterOf(value); 3090 DRegister value_odd = OddDRegisterOf(value);
3091 3091
3092 __ TryAllocate(compiler->float64x2_class(), 3092 __ TryAllocate(compiler->float64x2_class(),
3093 slow_path->entry_label(), 3093 slow_path->entry_label(),
3094 out_reg, 3094 out_reg,
3095 locs()->temp(0).reg()); 3095 locs()->temp(0).reg());
3096 __ Bind(slow_path->exit_label()); 3096 __ Bind(slow_path->exit_label());
3097 3097
3098 __ StoreDToOffset(value_even, out_reg, 3098 __ StoreDToOffset(value_even, out_reg,
3099 Float32x4::value_offset() - kHeapObjectTag); 3099 Float64x2::value_offset() - kHeapObjectTag);
3100 __ StoreDToOffset(value_odd, out_reg, 3100 __ StoreDToOffset(value_odd, out_reg,
3101 Float32x4::value_offset() + 2 * kWordSize - kHeapObjectTag); 3101 Float64x2::value_offset() + 2 * kWordSize - kHeapObjectTag);
3102 } 3102 }
3103 3103
3104 3104
3105 LocationSummary* UnboxFloat64x2Instr::MakeLocationSummary(bool opt) const { 3105 LocationSummary* UnboxFloat64x2Instr::MakeLocationSummary(bool opt) const {
3106 const intptr_t value_cid = value()->Type()->ToCid(); 3106 const intptr_t value_cid = value()->Type()->ToCid();
3107 const intptr_t kNumInputs = 1; 3107 const intptr_t kNumInputs = 1;
3108 const intptr_t kNumTemps = value_cid == kFloat64x2Cid ? 0 : 1; 3108 const intptr_t kNumTemps = value_cid == kFloat64x2Cid ? 0 : 1;
3109 LocationSummary* summary = 3109 LocationSummary* summary =
3110 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall); 3110 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
3111 summary->set_in(0, Location::RequiresRegister()); 3111 summary->set_in(0, Location::RequiresRegister());
(...skipping 1909 matching lines...) Expand 10 before | Expand all | Expand 10 after
5021 compiler->GenerateCall(token_pos(), 5021 compiler->GenerateCall(token_pos(),
5022 &label, 5022 &label,
5023 PcDescriptors::kOther, 5023 PcDescriptors::kOther,
5024 locs()); 5024 locs());
5025 __ Drop(2); // Discard type arguments and receiver. 5025 __ Drop(2); // Discard type arguments and receiver.
5026 } 5026 }
5027 5027
5028 } // namespace dart 5028 } // namespace dart
5029 5029
5030 #endif // defined TARGET_ARCH_ARM 5030 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | tests/lib/typed_data/float64x2_functional_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698