Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: ash/shelf/shelf_alignment_menu.cc

Issue 1743493002: Cleanup ash shelf accessor functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix ShelfBrowserTest. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shelf/shelf_alignment_menu.h" 5 #include "ash/shelf/shelf_alignment_menu.h"
6 6
7 #include "ash/metrics/user_metrics_recorder.h" 7 #include "ash/metrics/user_metrics_recorder.h"
8 #include "ash/shelf/shelf.h"
8 #include "ash/shelf/shelf_layout_manager.h" 9 #include "ash/shelf/shelf_layout_manager.h"
9 #include "ash/shelf/shelf_types.h" 10 #include "ash/shelf/shelf_types.h"
10 #include "ash/shell.h" 11 #include "ash/shell.h"
11 #include "grit/ash_strings.h" 12 #include "grit/ash_strings.h"
12 #include "ui/aura/window.h" 13 #include "ui/aura/window.h"
13 14
14 namespace ash { 15 namespace ash {
15 16
16 ShelfAlignmentMenu::ShelfAlignmentMenu(aura::Window* root) 17 ShelfAlignmentMenu::ShelfAlignmentMenu(aura::Window* root)
17 : ui::SimpleMenuModel(NULL), 18 : ui::SimpleMenuModel(NULL),
18 root_window_(root) { 19 root_window_(root) {
19 DCHECK(root_window_); 20 DCHECK(root_window_);
20 int align_group_id = 1; 21 int align_group_id = 1;
21 set_delegate(this); 22 set_delegate(this);
22 AddRadioItemWithStringId(MENU_ALIGN_LEFT, 23 AddRadioItemWithStringId(MENU_ALIGN_LEFT,
23 IDS_ASH_SHELF_CONTEXT_MENU_ALIGN_LEFT, 24 IDS_ASH_SHELF_CONTEXT_MENU_ALIGN_LEFT,
24 align_group_id); 25 align_group_id);
25 AddRadioItemWithStringId(MENU_ALIGN_BOTTOM, 26 AddRadioItemWithStringId(MENU_ALIGN_BOTTOM,
26 IDS_ASH_SHELF_CONTEXT_MENU_ALIGN_BOTTOM, 27 IDS_ASH_SHELF_CONTEXT_MENU_ALIGN_BOTTOM,
27 align_group_id); 28 align_group_id);
28 AddRadioItemWithStringId(MENU_ALIGN_RIGHT, 29 AddRadioItemWithStringId(MENU_ALIGN_RIGHT,
29 IDS_ASH_SHELF_CONTEXT_MENU_ALIGN_RIGHT, 30 IDS_ASH_SHELF_CONTEXT_MENU_ALIGN_RIGHT,
30 align_group_id); 31 align_group_id);
31 } 32 }
32 33
33 ShelfAlignmentMenu::~ShelfAlignmentMenu() {} 34 ShelfAlignmentMenu::~ShelfAlignmentMenu() {}
34 35
35 bool ShelfAlignmentMenu::IsCommandIdChecked(int command_id) const { 36 bool ShelfAlignmentMenu::IsCommandIdChecked(int command_id) const {
36 return ShelfLayoutManager::ForShelf(root_window_) 37 return Shelf::ForWindow(root_window_)
38 ->shelf_layout_manager()
37 ->SelectValueForShelfAlignment(MENU_ALIGN_BOTTOM == command_id, 39 ->SelectValueForShelfAlignment(MENU_ALIGN_BOTTOM == command_id,
38 MENU_ALIGN_LEFT == command_id, 40 MENU_ALIGN_LEFT == command_id,
39 MENU_ALIGN_RIGHT == command_id, 41 MENU_ALIGN_RIGHT == command_id, false);
40 false);
41 } 42 }
42 43
43 bool ShelfAlignmentMenu::IsCommandIdEnabled(int command_id) const { 44 bool ShelfAlignmentMenu::IsCommandIdEnabled(int command_id) const {
44 return true; 45 return true;
45 } 46 }
46 47
47 bool ShelfAlignmentMenu::GetAcceleratorForCommandId( 48 bool ShelfAlignmentMenu::GetAcceleratorForCommandId(
48 int command_id, 49 int command_id,
49 ui::Accelerator* accelerator) { 50 ui::Accelerator* accelerator) {
50 return false; 51 return false;
(...skipping 16 matching lines...) Expand all
67 case MENU_ALIGN_RIGHT: 68 case MENU_ALIGN_RIGHT:
68 Shell::GetInstance()->metrics()-> 69 Shell::GetInstance()->metrics()->
69 RecordUserMetricsAction(UMA_SHELF_ALIGNMENT_SET_RIGHT); 70 RecordUserMetricsAction(UMA_SHELF_ALIGNMENT_SET_RIGHT);
70 Shell::GetInstance()->SetShelfAlignment(SHELF_ALIGNMENT_RIGHT, 71 Shell::GetInstance()->SetShelfAlignment(SHELF_ALIGNMENT_RIGHT,
71 root_window_); 72 root_window_);
72 break; 73 break;
73 } 74 }
74 } 75 }
75 76
76 } // namespace ash 77 } // namespace ash
OLDNEW
« ash/shelf/shelf.h ('K') | « ash/shelf/shelf.cc ('k') | ash/shelf/shelf_layout_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698