Cleanup ash shelf accessor functions.

Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Make ShelfView take a Shelf* pointer; not ShelfLayoutManager.
Add Shelf alignment helpers to avoid ShelfLayoutManager use.

Miscellaneous refactoring of shelf object access callsites.

TODO: Remove Shell::[G|S]etShelfAutoHideBehavior
TODO: Remove Shell::[G|S]etShelfAlignment

BUG=557406
TEST=No regressions or behavior changes.
R=sky@chromium.org

Committed: https://crrev.com/a7e8a5f5cabcd125f82b6a204cf1210dad41a1f7
Cr-Commit-Position: refs/heads/master@{#378392}

[msw, 2016-02-26 22:37:15]

Description was changed from

==========
Cleanup static shelf accessor functions.

BUG=NONE
TEST=No regressions or behavior changes.
==========

to

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Use Shelf::ForWindow more to avoid RootWindowController use.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid these in shell.cc for ShelfDelegate ctor/init paths)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Miscellaneous refactoring of shelf object access callsites.

BUG=NONE
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

[msw, 2016-02-26 22:37:16]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-02-26 22:37:24]

Patchset #3 (id:40001) has been deleted

[msw, 2016-02-26 22:38:50]

Description was changed from

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Use Shelf::ForWindow more to avoid RootWindowController use.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid these in shell.cc for ShelfDelegate ctor/init paths)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Miscellaneous refactoring of shelf object access callsites.

BUG=NONE
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

to

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Miscellaneous refactoring of shelf object access callsites.

BUG=NONE
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

[msw, 2016-02-26 22:46:49]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 22:48:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743493002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743493002/60001

[msw, 2016-02-26 22:50:54]

Description was changed from

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Miscellaneous refactoring of shelf object access callsites.

BUG=NONE
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

to

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Miscellaneous refactoring of shelf object access callsites.

TODO: Remove Shell::[G|S]etShelfAutoHideBehavior
TODO: Remove Shell::[G|S]etShelfAlignment

BUG=NONE
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-02-26 23:17:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 23:17:14]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-02-26 23:34:39]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[msw, 2016-02-26 23:35:43]

Description was changed from

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Miscellaneous refactoring of shelf object access callsites.

TODO: Remove Shell::[G|S]etShelfAutoHideBehavior
TODO: Remove Shell::[G|S]etShelfAlignment

BUG=NONE
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

to

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Miscellaneous refactoring of shelf object access callsites.

TODO: Remove Shell::[G|S]etShelfAutoHideBehavior
TODO: Remove Shell::[G|S]etShelfAlignment

BUG=557406
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

[msw, 2016-02-26 23:36:10]

Hey Scott, please take a look; thanks!

[commit-bot: I haz the power, 2016-02-26 23:41:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743493002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743493002/80001

[commit-bot: I haz the power, 2016-02-27 01:31:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-27 01:31:45]

Dry run: This issue passed the CQ dry run.

[sky, 2016-02-29 16:38:39]

https://codereview.chromium.org/1743493002/diff/80001/ash/shelf/shelf.h
File ash/shelf/shelf.h (right):

https://codereview.chromium.org/1743493002/diff/80001/ash/shelf/shelf.h#newco...
ash/shelf/shelf.h:97: ShelfLayoutManager* shelf_layout_manager() {
Seems unfortunate that we expose the ShelfLayoutManager at all. Seems like Shelf
should expose the api and call through to the necessary places.

[msw, 2016-02-29 21:53:57]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 21:54:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743493002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743493002/100001

[msw, 2016-02-29 23:21:01]

Description was changed from

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Miscellaneous refactoring of shelf object access callsites.

TODO: Remove Shell::[G|S]etShelfAutoHideBehavior
TODO: Remove Shell::[G|S]etShelfAlignment

BUG=557406
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

to

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Make ShelfView take a Shelf* pointer; not ShelfLayoutManager.
Add Shelf alignment helpers to avoid ShelfLayoutManager use.

Miscellaneous refactoring of shelf object access callsites.

TODO: Remove Shell::[G|S]etShelfAutoHideBehavior
TODO: Remove Shell::[G|S]etShelfAlignment

BUG=557406
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

[msw, 2016-02-29 23:21:11]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 23:21:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743493002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743493002/140001

[msw, 2016-02-29 23:23:44]

Hey Scott, please take another look; thanks!

https://codereview.chromium.org/1743493002/diff/80001/ash/shelf/shelf.h
File ash/shelf/shelf.h (right):

https://codereview.chromium.org/1743493002/diff/80001/ash/shelf/shelf.h#newco...
ash/shelf/shelf.h:97: ShelfLayoutManager* shelf_layout_manager() {
On 2016/02/29 16:38:39, sky wrote:
> Seems unfortunate that we expose the ShelfLayoutManager at all. Seems like
Shelf
> should expose the api and call through to the necessary places.

Agreed; I tackled some low-hanging fruit and added a TODO here. It'll take many
more followup changes to totally encapsulate ShelfLayoutManager.

[commit-bot: I haz the power, 2016-03-01 00:09:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 00:09:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-03-01 00:33:41]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 00:34:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743493002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743493002/160001

[commit-bot: I haz the power, 2016-03-01 01:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 01:37:45]

Dry run: This issue passed the CQ dry run.

[sky, 2016-03-01 03:48:27]

Ok, LGTM

[msw, 2016-03-01 04:08:20]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-03-01 04:08:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743493002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743493002/160001

[commit-bot: I haz the power, 2016-03-01 04:15:13]

Description was changed from

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Make ShelfView take a Shelf* pointer; not ShelfLayoutManager.
Add Shelf alignment helpers to avoid ShelfLayoutManager use.

Miscellaneous refactoring of shelf object access callsites.

TODO: Remove Shell::[G|S]etShelfAutoHideBehavior
TODO: Remove Shell::[G|S]etShelfAlignment

BUG=557406
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

to

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Make ShelfView take a Shelf* pointer; not ShelfLayoutManager.
Add Shelf alignment helpers to avoid ShelfLayoutManager use.

Miscellaneous refactoring of shelf object access callsites.

TODO: Remove Shell::[G|S]etShelfAutoHideBehavior
TODO: Remove Shell::[G|S]etShelfAlignment

BUG=557406
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-03-01 04:15:14]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2016-03-01 04:17:21]

Description was changed from

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Make ShelfView take a Shelf* pointer; not ShelfLayoutManager.
Add Shelf alignment helpers to avoid ShelfLayoutManager use.

Miscellaneous refactoring of shelf object access callsites.

TODO: Remove Shell::[G|S]etShelfAutoHideBehavior
TODO: Remove Shell::[G|S]etShelfAlignment

BUG=557406
TEST=No regressions or behavior changes.
R=sky@chromium.org
==========

to

==========
Cleanup ash shelf accessor functions.

Remove RootWindowController::ForShelf, use ForWindow instead.
Remove ShelfLayoutManager::ForShelf, use Shelf::For*, etc.

Avoid direct RootWindowController use with Shelf::ForWindow.
Add Shelf::shelf_layout_manager() accessor via ShelfWidget.
(avoid Shelf::ForWindow in shell.cc for ShelfDelegate init path)
(No Shelf exists for ShelfWidget::CreateShelf's delegate init)

Make ShelfView take a Shelf* pointer; not ShelfLayoutManager.
Add Shelf alignment helpers to avoid ShelfLayoutManager use.

Miscellaneous refactoring of shelf object access callsites.

TODO: Remove Shell::[G|S]etShelfAutoHideBehavior
TODO: Remove Shell::[G|S]etShelfAlignment

BUG=557406
TEST=No regressions or behavior changes.
R=sky@chromium.org

Committed: https://crrev.com/a7e8a5f5cabcd125f82b6a204cf1210dad41a1f7
Cr-Commit-Position: refs/heads/master@{#378392}
==========

[commit-bot: I haz the power, 2016-03-01 04:17:22]

Patchset 8 (id:??) landed as
https://crrev.com/a7e8a5f5cabcd125f82b6a204cf1210dad41a1f7
Cr-Commit-Position: refs/heads/master@{#378392}