Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: mojo/public/tools/manifest/manifest_collator.py

Issue 1743473002: Change Mojo URLs to structured names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@18collapse
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/manifest/manifest_collator.py
diff --git a/mojo/public/tools/manifest/manifest_collator.py b/mojo/public/tools/manifest/manifest_collator.py
index 7acc76be7461bced25b7387f83182e401e28354f..a7dcc623add69eec89891eadca8c054c75ff748f 100755
--- a/mojo/public/tools/manifest/manifest_collator.py
+++ b/mojo/public/tools/manifest/manifest_collator.py
@@ -31,11 +31,11 @@ def main():
if parent == None:
return 1
- parsed = urlparse.urlparse(parent['url'])
- if args.application_name != parsed.hostname:
+ app_path = parent['name'].split(':')[1]
sky 2016/02/26 18:37:27 Error checking if split(':') returns a list of one
+ if args.application_name != app_path:
raise ValueError("Application name '%s' specified in build file does not " \
"match application name '%s' specified in manifest." %
- (args.application_name, parsed.hostname))
+ (args.application_name, app_path))
applications = []
for child in children:

Powered by Google App Engine
This is Rietveld 408576698