Change Mojo URLs to structured names

Change Mojo URLs to structured names.

type:path

Remove GURLs from all over the place. This eliminates the need to register Mojo and Exe schemes.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/c6eb8ad71579f9945976e5b4b4915f084388e5ae
Cr-Commit-Position: refs/heads/master@{#378130}

[Ben Goodger (Google), 2016-02-26 05:58:16]

Description was changed from

==========
Name

BUG=
==========

to

==========
Name

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2016-02-26 18:04:44]

Description was changed from

==========
Name

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change Mojo URLs to structured names.

type:path

Remove GURLs from all over the place. This eliminates the need to register Mojo
and Exe schemes.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2016-02-26 18:04:44]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[Ben Goodger (Google), 2016-02-26 18:05:09]

I need to add some documentation to the names.h headers describing the name
syntax but I figured this was ready for review.

[sky, 2016-02-26 18:37:27]

You should be able to nuke mojo_scheme_register now.

Also, make sure you do a search for mojo:// and exe:// . I think you missed a
couple: ash/mus/keyboard_ui_mus.cc for one.

https://codereview.chromium.org/1743473002/diff/80001/content/browser/frame_h...
File content/browser/frame_host/frame_mojo_shell.cc (right):

https://codereview.chromium.org/1743473002/diff/80001/content/browser/frame_h...
content/browser/frame_host/frame_mojo_shell.cc:51: const mojo::String&
application_url,
application? or application_name?

https://codereview.chromium.org/1743473002/diff/80001/content/browser/mojo_sh...
File content/browser/mojo_shell_browsertest.cc (right):

https://codereview.chromium.org/1743473002/diff/80001/content/browser/mojo_sh...
content/browser/mojo_shell_browsertest.cc:18: const char
kInProcessTestMojoAppUrl[] = "system:content_in_process_test_app";
AppName?

https://codereview.chromium.org/1743473002/diff/80001/mojo/public/tools/manif...
File mojo/public/tools/manifest/manifest_collator.py (right):

https://codereview.chromium.org/1743473002/diff/80001/mojo/public/tools/manif...
mojo/public/tools/manifest/manifest_collator.py:34: app_path =
parent['name'].split(':')[1]
Error checking if split(':') returns a list of one element? Also, what about
error checking that app_path doesn't start with '//'?

https://codereview.chromium.org/1743473002/diff/80001/mojo/services/package_m...
File mojo/services/package_manager/package_manager.cc (right):

https://codereview.chromium.org/1743473002/diff/80001/mojo/services/package_m...
mojo/services/package_manager/package_manager.cc:43:
CHECK(value.GetString(ApplicationCatalogStore::kNameKey, &name_string));
Is it worth error checking that the name has a ':' and the second part doesn't
start with '//'?

https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/background/t...
File mojo/shell/background/tests/background_shell_unittest.cc (right):

https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/background/t...
mojo/shell/background/tests/background_shell_unittest.cc:19: const char
kTestUrl[] = "mojo:test-app";
kTestName?

https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/public/cpp/l...
File mojo/shell/public/cpp/lib/names.cc (right):

https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/public/cpp/l...
mojo/shell/public/cpp/lib/names.cc:15: return parts.size() == 2 &&
!parts.front().empty() && !parts.back().empty();
Is it worth making sure parts.back() doesn't start with '//' in the short term?

https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/tests/applic...
File mojo/shell/tests/application_manager_unittest.cc (right):

https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/tests/applic...
mojo/shell/tests/application_manager_unittest.cc:112: std::string
last_requestor_name() const { return last_requestor_name_; }
const std::string&

[Ben Goodger (Google), 2016-02-26 19:09:33]

On 2016/02/26 18:37:27, sky wrote:
> You should be able to nuke mojo_scheme_register now.
> 
> Also, make sure you do a search for mojo:// and exe:// . I think you missed a
> couple: ash/mus/keyboard_ui_mus.cc for one.
> 
>
https://codereview.chromium.org/1743473002/diff/80001/content/browser/frame_h...
> File content/browser/frame_host/frame_mojo_shell.cc (right):
> 
>
https://codereview.chromium.org/1743473002/diff/80001/content/browser/frame_h...
> content/browser/frame_host/frame_mojo_shell.cc:51: const mojo::String&
> application_url,
> application? or application_name?
> 
>
https://codereview.chromium.org/1743473002/diff/80001/content/browser/mojo_sh...
> File content/browser/mojo_shell_browsertest.cc (right):
> 
>
https://codereview.chromium.org/1743473002/diff/80001/content/browser/mojo_sh...
> content/browser/mojo_shell_browsertest.cc:18: const char
> kInProcessTestMojoAppUrl[] = "system:content_in_process_test_app";
> AppName?
> 
>
https://codereview.chromium.org/1743473002/diff/80001/mojo/public/tools/manif...
> File mojo/public/tools/manifest/manifest_collator.py (right):
> 
>
https://codereview.chromium.org/1743473002/diff/80001/mojo/public/tools/manif...
> mojo/public/tools/manifest/manifest_collator.py:34: app_path =
> parent['name'].split(':')[1]
> Error checking if split(':') returns a list of one element? Also, what about
> error checking that app_path doesn't start with '//'?
> 
>
https://codereview.chromium.org/1743473002/diff/80001/mojo/services/package_m...
> File mojo/services/package_manager/package_manager.cc (right):
> 
>
https://codereview.chromium.org/1743473002/diff/80001/mojo/services/package_m...
> mojo/services/package_manager/package_manager.cc:43:
> CHECK(value.GetString(ApplicationCatalogStore::kNameKey, &name_string));
> Is it worth error checking that the name has a ':' and the second part doesn't
> start with '//'?
> 
>
https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/background/t...
> File mojo/shell/background/tests/background_shell_unittest.cc (right):
> 
>
https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/background/t...
> mojo/shell/background/tests/background_shell_unittest.cc:19: const char
> kTestUrl[] = "mojo:test-app";
> kTestName?
> 
>
https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/public/cpp/l...
> File mojo/shell/public/cpp/lib/names.cc (right):
> 
>
https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/public/cpp/l...
> mojo/shell/public/cpp/lib/names.cc:15: return parts.size() == 2 &&
> !parts.front().empty() && !parts.back().empty();
> Is it worth making sure parts.back() doesn't start with '//' in the short
term?
> 
>
https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/tests/applic...
> File mojo/shell/tests/application_manager_unittest.cc (right):
> 
>
https://codereview.chromium.org/1743473002/diff/80001/mojo/shell/tests/applic...
> mojo/shell/tests/application_manager_unittest.cc:112: std::string
> last_requestor_name() const { return last_requestor_name_; }
> const std::string&

Updated PTAL

[sky, 2016-02-26 20:12:07]

LGTM

[Ben Goodger (Google), 2016-02-26 20:15:49]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-02-26 20:18:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/140001

[commit-bot: I haz the power, 2016-02-26 20:37:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 20:37:31]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2016-02-26 20:41:22]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-26 20:41:22]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1743473002/#ps160001
(title: ".")

[commit-bot: I haz the power, 2016-02-26 20:41:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/160001

[commit-bot: I haz the power, 2016-02-26 20:54:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 20:54:01]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2016-02-26 21:11:37]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-26 21:11:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1743473002/#ps180001
(title: ".")

[commit-bot: I haz the power, 2016-02-26 21:13:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/180001

[commit-bot: I haz the power, 2016-02-26 21:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 21:37:45]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2016-02-26 22:04:47]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-26 22:04:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1743473002/#ps200001
(title: ".")

[commit-bot: I haz the power, 2016-02-26 22:05:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/200001

[commit-bot: I haz the power, 2016-02-26 22:22:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 22:22:47]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-26 22:35:11]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-26 22:35:12]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1743473002/#ps220001
(title: ".")

[commit-bot: I haz the power, 2016-02-26 22:36:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/220001

[commit-bot: I haz the power, 2016-02-26 22:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 22:58:41]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-27 03:11:19]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-27 03:11:20]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1743473002/#ps240001
(title: ".")

[commit-bot: I haz the power, 2016-02-27 03:12:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/240001

[commit-bot: I haz the power, 2016-02-27 03:41:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-27 03:41:40]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-27 03:45:12]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-27 03:45:13]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1743473002/#ps260001
(title: ".")

[commit-bot: I haz the power, 2016-02-27 03:45:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/260001

[commit-bot: I haz the power, 2016-02-27 04:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-27 04:06:42]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-27 04:36:50]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-27 04:36:51]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1743473002/#ps280001
(title: ".")

[commit-bot: I haz the power, 2016-02-27 04:37:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/280001

[commit-bot: I haz the power, 2016-02-27 05:12:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-27 05:12:03]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-27 05:59:19]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-27 05:59:20]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1743473002/#ps300001
(title: ".")

[commit-bot: I haz the power, 2016-02-27 05:59:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/300001

[commit-bot: I haz the power, 2016-02-27 06:10:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-27 06:10:16]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-27 06:18:06]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-02-27 06:18:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/300001

[commit-bot: I haz the power, 2016-02-27 06:23:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-27 06:23:12]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ben Goodger (Google), 2016-02-27 06:35:42]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-02-27 06:36:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/300001

[commit-bot: I haz the power, 2016-02-27 07:05:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-27 07:05:19]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-27 07:23:43]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-27 07:23:45]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1743473002/#ps320001
(title: ".")

[commit-bot: I haz the power, 2016-02-27 07:24:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743473002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743473002/320001

[commit-bot: I haz the power, 2016-02-27 08:53:39]

Description was changed from

==========
Change Mojo URLs to structured names.

type:path

Remove GURLs from all over the place. This eliminates the need to register Mojo
and Exe schemes.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change Mojo URLs to structured names.

type:path

Remove GURLs from all over the place. This eliminates the need to register Mojo
and Exe schemes.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-02-27 08:53:42]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2016-02-27 08:54:30]

Description was changed from

==========
Change Mojo URLs to structured names.

type:path

Remove GURLs from all over the place. This eliminates the need to register Mojo
and Exe schemes.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change Mojo URLs to structured names.

type:path

Remove GURLs from all over the place. This eliminates the need to register Mojo
and Exe schemes.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/c6eb8ad71579f9945976e5b4b4915f084388e5ae
Cr-Commit-Position: refs/heads/master@{#378130}
==========

[commit-bot: I haz the power, 2016-02-27 08:54:32]

Patchset 17 (id:??) landed as
https://crrev.com/c6eb8ad71579f9945976e5b4b4915f084388e5ae
Cr-Commit-Position: refs/heads/master@{#378130}