Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 1743463004: Make %TypedArray%.from spec-compliant (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 9 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make %TypedArray%.from spec-compliant This patch fixes %TypedArray%.from to follow the ES2016 draft spec more precisely. Specifically, the input is first converted to an ArrayLike, and then afterwards, the mapping function is run and the results written into the TypedArray. This fixes a test262 test. R=adamk LOG=Y BUG=v8:4782 Committed: https://crrev.com/2765a0609a8aed612a3e34d9f9897d9ec7fc969e Cr-Commit-Position: refs/heads/master@{#34373}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Construct array result better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M src/js/typedarray.js View 1 3 chunks +49 lines, -9 lines 0 comments Download
M test/test262/test262.status View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743463004/1
4 years, 10 months ago (2016-02-26 21:28:21 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-26 21:53:37 UTC) #4
Dan Ehrenberg
4 years, 10 months ago (2016-02-26 21:55:45 UTC) #5
adamk
https://codereview.chromium.org/1743463004/diff/1/src/js/typedarray.js File src/js/typedarray.js (right): https://codereview.chromium.org/1743463004/diff/1/src/js/typedarray.js#newcode771 src/js/typedarray.js:771: var array = new GlobalArray(); Can you use an ...
4 years, 10 months ago (2016-02-26 22:18:48 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743463004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743463004/20001
4 years, 9 months ago (2016-02-29 23:24:36 UTC) #8
Dan Ehrenberg
https://codereview.chromium.org/1743463004/diff/1/src/js/typedarray.js File src/js/typedarray.js (right): https://codereview.chromium.org/1743463004/diff/1/src/js/typedarray.js#newcode771 src/js/typedarray.js:771: var array = new GlobalArray(); On 2016/02/26 at 22:18:48, ...
4 years, 9 months ago (2016-02-29 23:24:44 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 23:42:13 UTC) #11
adamk
lgtm
4 years, 9 months ago (2016-03-01 02:22:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743463004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743463004/20001
4 years, 9 months ago (2016-03-01 02:38:49 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 02:40:35 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 02:41:48 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2765a0609a8aed612a3e34d9f9897d9ec7fc969e
Cr-Commit-Position: refs/heads/master@{#34373}

Powered by Google App Engine
This is Rietveld 408576698