Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1743433002: Revert of [compiler] Drop the CompareNilIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen-types.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 4021 matching lines...) Expand 10 before | Expand all | Expand 10 after
4032 VisitForAccumulatorValue(sub_expr); 4032 VisitForAccumulatorValue(sub_expr);
4033 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 4033 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
4034 if (expr->op() == Token::EQ_STRICT) { 4034 if (expr->op() == Token::EQ_STRICT) {
4035 Heap::RootListIndex nil_value = nil == kNullValue ? 4035 Heap::RootListIndex nil_value = nil == kNullValue ?
4036 Heap::kNullValueRootIndex : 4036 Heap::kNullValueRootIndex :
4037 Heap::kUndefinedValueRootIndex; 4037 Heap::kUndefinedValueRootIndex;
4038 __ LoadRoot(r1, nil_value); 4038 __ LoadRoot(r1, nil_value);
4039 __ cmp(r0, r1); 4039 __ cmp(r0, r1);
4040 Split(eq, if_true, if_false, fall_through); 4040 Split(eq, if_true, if_false, fall_through);
4041 } else { 4041 } else {
4042 __ JumpIfSmi(r0, if_false); 4042 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil);
4043 __ ldr(r0, FieldMemOperand(r0, HeapObject::kMapOffset)); 4043 CallIC(ic, expr->CompareOperationFeedbackId());
4044 __ ldrb(r1, FieldMemOperand(r0, Map::kBitFieldOffset)); 4044 __ CompareRoot(r0, Heap::kTrueValueRootIndex);
4045 __ tst(r1, Operand(1 << Map::kIsUndetectable)); 4045 Split(eq, if_true, if_false, fall_through);
4046 Split(ne, if_true, if_false, fall_through);
4047 } 4046 }
4048 context()->Plug(if_true, if_false); 4047 context()->Plug(if_true, if_false);
4049 } 4048 }
4050 4049
4051 4050
4052 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 4051 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
4053 __ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 4052 __ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
4054 context()->Plug(r0); 4053 context()->Plug(r0);
4055 } 4054 }
4056 4055
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
4307 DCHECK(interrupt_address == 4306 DCHECK(interrupt_address ==
4308 isolate->builtins()->OsrAfterStackCheck()->entry()); 4307 isolate->builtins()->OsrAfterStackCheck()->entry());
4309 return OSR_AFTER_STACK_CHECK; 4308 return OSR_AFTER_STACK_CHECK;
4310 } 4309 }
4311 4310
4312 4311
4313 } // namespace internal 4312 } // namespace internal
4314 } // namespace v8 4313 } // namespace v8
4315 4314
4316 #endif // V8_TARGET_ARCH_ARM 4315 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen-types.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698