chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsManager.java - Issue 1743333002: [NTP Snippets] Implement snippets expiry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsManager.java

Issue 1743333002: [NTP Snippets] Implement snippets expiry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_persist

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsManager.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsManager.java

index 7faf17a08a657ffa80ac0a569163222b62c7bc4c..16d74ade3a6fa20d24fc1f42f006bc3241f95486 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsManager.java

@@ -105,6 +105,7 @@ public class SnippetsManager {

@Override

protected Drawable doInBackground(String... params) {

+ if (params[0].isEmpty()) return null;

Marc Treib 2016/02/29 17:44:51 Totally unrelated - this gets rid of a lot of usel

Bernhard Bauer 2016/03/01 11:05:04 Acknowledged.

InputStream is = null;

try {

is = (InputStream) new URL(params[0]).getContent();

« no previous file with comments | « no previous file | components/ntp_snippets/ntp_snippet.cc » ('j') | components/ntp_snippets/ntp_snippets_service.cc » ('J')