S390: Initial impl of debug and ic

S390: Initial impl of debug and ic

Initial implementation of S390 specific debug and IC functions.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com
BUG=

Committed: https://crrev.com/503d58934051eedcdcb6cbcf06bb43fd92239573
Cr-Commit-Position: refs/heads/master@{#34400}

[JoranSiu, 2016-02-29 18:02:27]

The CQ bit was checked by joransiu@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 18:02:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743263003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743263003/1

[commit-bot: I haz the power, 2016-02-29 18:27:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 18:27:26]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2016-03-01 09:57:41]

LGTM if you fix BUILD.gn.

(Reviewed build files, rubberstamping the rest)

https://codereview.chromium.org/1743263003/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1743263003/diff/1/BUILD.gn#newcode1587
BUILD.gn:1587: "src/debug/s390/debug-s390.cc",
Surely this was supposed to go in the 'if (v8_target_arch == "s390" ||
v8_target_arch == "s390x")' section below?

[Yang, 2016-03-01 10:56:37]

On 2016/03/01 09:57:41, Jakob wrote:
> LGTM if you fix BUILD.gn.
> 
> (Reviewed build files, rubberstamping the rest)
> 
> https://codereview.chromium.org/1743263003/diff/1/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/1743263003/diff/1/BUILD.gn#newcode1587
> BUILD.gn:1587: "src/debug/s390/debug-s390.cc",
> Surely this was supposed to go in the 'if (v8_target_arch == "s390" ||
> v8_target_arch == "s390x")' section below?

rubberstamp lgtm for src/debug/s390

[JoranSiu, 2016-03-01 16:13:10]

On 2016/03/01 10:56:37, Yang wrote:
> On 2016/03/01 09:57:41, Jakob wrote:
> > LGTM if you fix BUILD.gn.
> > 
> > (Reviewed build files, rubberstamping the rest)
> > 
> > https://codereview.chromium.org/1743263003/diff/1/BUILD.gn
> > File BUILD.gn (right):
> > 
> > https://codereview.chromium.org/1743263003/diff/1/BUILD.gn#newcode1587
> > BUILD.gn:1587: "src/debug/s390/debug-s390.cc",
> > Surely this was supposed to go in the 'if (v8_target_arch == "s390" ||
> > v8_target_arch == "s390x")' section below?
> 
> rubberstamp lgtm for src/debug/s390

Thanks for reviews, and catching the issue in BUILD.gn!  I've updated the latest
patch with the BUILD.gn changes fixed.

[Jakob Kummerow, 2016-03-01 16:34:24]

Alright, looks good now, feel free to land.

[JoranSiu, 2016-03-01 16:39:49]

The CQ bit was checked by joransiu@ca.ibm.com

[JoranSiu, 2016-03-01 16:39:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1743263003/#ps20001
(title: "Fix s390 files under correct target in BUILD.gn")

[commit-bot: I haz the power, 2016-03-01 16:39:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743263003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743263003/20001

[commit-bot: I haz the power, 2016-03-01 17:00:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-01 17:01:49]

Description was changed from

==========
S390: Initial impl of debug and ic

Initial implementation of S390 specific debug and IC functions.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.c...
BUG=
==========

to

==========
S390: Initial impl of debug and ic

Initial implementation of S390 specific debug and IC functions.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.c...
BUG=

Committed: https://crrev.com/503d58934051eedcdcb6cbcf06bb43fd92239573
Cr-Commit-Position: refs/heads/master@{#34400}
==========

[commit-bot: I haz the power, 2016-03-01 17:01:51]

Patchset 2 (id:??) landed as
https://crrev.com/503d58934051eedcdcb6cbcf06bb43fd92239573
Cr-Commit-Position: refs/heads/master@{#34400}